You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/01/12 19:37:54 UTC

[jira] Created: (HIVE-1045) (bigint % int) should return bigint instead of double

(bigint % int) should return bigint instead of double
-----------------------------------------------------

                 Key: HIVE-1045
                 URL: https://issues.apache.org/jira/browse/HIVE-1045
             Project: Hadoop Hive
          Issue Type: Bug
            Reporter: Zheng Shao


This expression should return bigint instead of double.

{code}
CREATE TABLE test (a BIGINT);
EXPLAIN SELECT a % 3 FROM test;
{code}

There must be something wrong in {{FunctionRegistry.getMethodInternal}}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799480#action_12799480 ] 

Zheng Shao commented on HIVE-1045:
----------------------------------

Looks good. I will test and commit if tests pass.


> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1045:
-----------------------------

    Affects Version/s: 0.6.0
                       0.5.0

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1045:
---------------------------------

      Component/s: Query Processor
    Fix Version/s:     (was: 0.6.0)

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>             Fix For: 0.5.0
>
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch, HIVE-1045.3.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Yang updated HIVE-1045:
----------------------------

    Attachment: HIVE-1045.2.patch

Fixed test case. I'm re-running the test suite but if  your run finishes or has an error before mine does, please let me know.

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Yang updated HIVE-1045:
----------------------------

    Attachment:     (was: HIVE-1045.3.patch)

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Yang updated HIVE-1045:
----------------------------

    Attachment: HIVE-1045.3.patch

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch, HIVE-1045.3.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799510#action_12799510 ] 

Zheng Shao commented on HIVE-1045:
----------------------------------

There are 3 failures (in trunk):

.ptest_1/test.17.2.1.log:    [junit] Begin query: input8.q
.ptest_1/test.17.2.1.log:    [junit] junit.framework.AssertionFailedError: Client execution results failed with error code = 1
--
.ptest_1/test.17.2.1.log:    [junit] Begin query: ppd_constant_expr.q
.ptest_1/test.17.2.1.log:    [junit] junit.framework.AssertionFailedError: Client execution results failed with error code = 1
--
.ptest_3/test.17.2.1.log:    [junit] Begin query: input8.q
.ptest_3/test.17.2.1.log:    [junit] junit.framework.AssertionFailedError: Semantic Analysis has unexpected output with error code = 1
--


> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799558#action_12799558 ] 

Zheng Shao commented on HIVE-1045:
----------------------------------

Still fails. It seems that running a single test produced different result from running multiple tests for TestParse.

Can you verify that and (if necessary) open another JIRA?

{code}
    [junit] diff -b -I'\(\(<java version=".*" class="java.beans.XMLDecoder">\)\|\(<string>.*/tmp/.*</string>\)\|\(<string>file:.*</string>\)\|\(<string>[0-9]\{10\}</string>\)\|\(<string>/.*\
/warehouse/.*</string>\)\)' /data/users/zshao/hadoop_hive/trunk/.ptest_3/build/ql/test/logs/positive/input8.q.xml /data/users/zshao/hadoop_hive/trunk/.ptest_3/ql/src/test/results/compiler/p\
lan/input8.q.xml
    [junit] 150c150
    [junit] <                    <string>CNTR_NAME_FS_312_NUM_INPUT_ROWS</string>
    [junit] ---
    [junit] >                    <string>CNTR_NAME_FS_2_NUM_INPUT_ROWS</string>
    [junit] 153c153
    [junit] <                    <string>CNTR_NAME_FS_312_NUM_OUTPUT_ROWS</string>
    [junit] ---
    [junit] >                    <string>CNTR_NAME_FS_2_NUM_OUTPUT_ROWS</string>
    [junit] 156c156
    [junit] Exception: Semantic Analysis has unexpected output with error code = 1
    [junit] <                    <string>CNTR_NAME_FS_312_TIME_TAKEN</string>
    [junit] ---
    [junit] >                    <string>CNTR_NAME_FS_2_TIME_TAKEN</string>
    [junit] 159c159
    [junit] <                    <string>CNTR_NAME_FS_312_FATAL_ERROR</string>
    [junit] ---
    [junit] >                    <string>CNTR_NAME_FS_2_FATAL_ERROR</string>
{code}


> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Yang updated HIVE-1045:
----------------------------

    Attachment: HIVE-1045.3.patch

* Update after HIVE-1048

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Yang reassigned HIVE-1045:
-------------------------------

    Assignee: Paul Yang

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao resolved HIVE-1045.
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6.0
                   0.5.0
     Release Note: HIVE-1045. (bigint % int) should return bigint instead of double. (Paul Yang via zshao)
     Hadoop Flags: [Reviewed]

Committed. Thanks Paul!

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>             Fix For: 0.5.0, 0.6.0
>
>         Attachments: HIVE-1045.1.patch, HIVE-1045.2.patch, HIVE-1045.3.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1045) (bigint % int) should return bigint instead of double

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Yang updated HIVE-1045:
----------------------------

    Attachment: HIVE-1045.1.patch

Posting a little early - in the process of running full test suite

> (bigint % int) should return bigint instead of double
> -----------------------------------------------------
>
>                 Key: HIVE-1045
>                 URL: https://issues.apache.org/jira/browse/HIVE-1045
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Paul Yang
>         Attachments: HIVE-1045.1.patch
>
>
> This expression should return bigint instead of double.
> {code}
> CREATE TABLE test (a BIGINT);
> EXPLAIN SELECT a % 3 FROM test;
> {code}
> There must be something wrong in {{FunctionRegistry.getMethodInternal}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.