You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Jacob Kjome <ho...@visi.com> on 2005/01/07 09:19:04 UTC

DOMConfigurator configure methods?

Hi Ceki,

I see you simply had DOMConfigurator extend JoranConfigurator and kept one 
static configure() method which you delegate to the corresponding 
JoranConfigurator instance method.  If this is meant to keep compatibility 
with code referencing DOMConfigurator, I'm not sure it is doing its 
job.  Shouldn't DOMConfigurator also have static configure methods taking a 
URL and an Element, respectively, in the same style as the existing 
configure method that takes a String?

Jake


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Re: DOMConfigurator configure methods?

Posted by Jacob Kjome <ho...@visi.com>.
At 11:58 AM 1/7/2005 +0100, you wrote:
 >At 09:19 AM 1/7/2005, Jacob Kjome wrote:
 >
 >>Hi Ceki,
 >>
 >>I see you simply had DOMConfigurator extend JoranConfigurator and kept one
 >>static configure() method which you delegate to the corresponding
 >>JoranConfigurator instance method.  If this is meant to keep compatibility
 >>with code referencing DOMConfigurator, I'm not sure it is doing its
 >>job.  Shouldn't DOMConfigurator also have static configure methods taking
 >>a URL and an Element, respectively, in the same style as the existing
 >>configure method that takes a String?
 >
 >Correct. I was hoping to defer their inclusion until someone complained.
 >Are you complaining or just observing? :-)
 >

Which one will provide parity with Log4j-1.2?  Complaining?  Ok, then I'm 
complaining :-)   The reason I'd like this is that I want my 
InitShutdownController to be compatible with both Log4j-1.2.x and 
Log4j-1.3.x.  Currently, I'm using reflection to see if JoranConfigurator 
is available and, if so, using that.  However, in the case that it isn't 
available, and the config file is log4j.xml, then I use the DOMConfigurator 
with the URL option.  In order to compile against both versions of Log4j, I 
need, at a minimum, the configure(URL) static method available.

Jake

 >>Jake
 >
 >--
 >Ceki Gülcü
 >
 >   The complete log4j manual: http://www.qos.ch/log4j/
 >
 >
 >
 >---------------------------------------------------------------------
 >To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
 >For additional commands, e-mail: log4j-dev-help@logging.apache.org
 >
 >  


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Re: DOMConfigurator configure methods?

Posted by Ceki Gülcü <ce...@qos.ch>.
At 09:19 AM 1/7/2005, Jacob Kjome wrote:

>Hi Ceki,
>
>I see you simply had DOMConfigurator extend JoranConfigurator and kept one 
>static configure() method which you delegate to the corresponding 
>JoranConfigurator instance method.  If this is meant to keep compatibility 
>with code referencing DOMConfigurator, I'm not sure it is doing its 
>job.  Shouldn't DOMConfigurator also have static configure methods taking 
>a URL and an Element, respectively, in the same style as the existing 
>configure method that takes a String?

Correct. I was hoping to defer their inclusion until someone complained. 
Are you complaining or just observing? :-)

>Jake

-- 
Ceki Gülcü

   The complete log4j manual: http://www.qos.ch/log4j/



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org