You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2026/10/15 06:42:48 UTC
[PR] [fix](be) Preserve valid types for date defaults [doris]
csun5285 opened a new pull request, #69120:
URL: https://github.com/apache/doris/pull/69120
### What problem does this PR solve?
Issue Number: None
Related PR: #69070
Problem Summary: `VecDateTimeValue` used the compute-layer `TYPE_DATETIME` enum where a storage-layer `TimeType` was required. The value was truncated into an invalid three-bit type, so default DATE and DATETIME values could serialize to an empty string and produce invalid temporal bounds. Use `TIME_DATETIME` for the shared temporal constants, normalize DATE column defaults to `TIME_DATE`, and add coverage for the type and serialized value.
### Release note
None
### Check List (For Author)
- Test: BE build and unit tests were run in the corresponding write-path worktree with precompiled third-party dependencies and `-j 128`.
- `DISABLE_BE_JAVA_EXTENSIONS=ON ./build.sh --be -j 128` passed.
- The targeted default-value tests passed.
- The full BE unit-test run had 14990 passed; 4 unrelated `SniiBatchRangeFetcher` tests failed because `/tmp/snii_brf_ramp.bin` was owned by another user; 33 tests were disabled.
- Behavior changed: Yes. Default DATE and DATETIME values now retain valid storage types and canonical serialization.
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6192192989
<details>
<summary>TPC-DS: <b>Total hot run time: 153223 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 235def26618e0b31905de046c280a8c565238292, data reload: false
query5 4314 588 458 458
query6 440 209 188 188
query7 4808 444 230 230
query8 319 175 161 161
query9 8757 4062 4031 4031
query10 465 319 268 268
query11 5897 3800 3532 3532
query12 151 92 86 86
query13 1249 433 317 317
query14 6086 4092 3843 3843
query14_1 3602 3605 3584 3584
query15 209 205 178 178
query16 946 451 438 438
query17 867 666 571 571
query18 2427 422 326 326
query19 199 159 137 137
query20 87 87 86 86
query21 214 141 115 115
query22 12986 13129 12869 12869
query23 13683 12958 12511 12511
query23_1 12663 12530 12536 12530
query24 7090 834 469 469
query24_1 478 497 483 483
query25 553 426 374 374
query26 1331 264 145 145
query27 2747 446 283 283
query28 4616 1963 1987 1963
query29 1613 611 467 467
query30 301 225 194 194
query31 1016 928 805 805
query32 154 135 91 91
query33 510 304 235 235
query34 907 851 510 510
query35 760 753 635 635
query36 795 795 720 720
query37 130 102 89 89
query38 1806 1770 1679 1679
query39 800 789 756 756
query39_1 742 731 746 731
query40 217 115 96 96
query41 67 62 62 62
query42 85 90 83 83
query43 367 388 334 334
query44 1294 715 700 700
query45 180 177 164 164
query46 842 958 571 571
query47 2977 2973 2938 2938
query48 301 307 219 219
query49 575 398 294 294
query50 686 280 214 214
query51 10438 10637 10599 10599
query52 80 78 69 69
query53 187 206 155 155
query54 227 191 190 190
query55 71 73 68 68
query56 217 205 206 205
query57 1612 1591 1545 1545
query58 293 262 260 260
query59 2133 2141 1958 1958
query60 295 242 232 232
query61 148 178 147 147
query62 400 338 288 288
query63 198 162 168 162
query64 2721 940 770 770
query65 3311 3270 3244 3244
query66 1786 416 301 301
query67 20179 20081 21695 20081
query68 3254 1004 624 624
query69 408 282 243 243
query70 888 818 853 818
query71 313 229 197 197
query72 2837 2778 2387 2387
query73 527 521 304 304
query74 4631 4459 4331 4331
query75 2355 2289 1968 1968
query76 2379 1020 633 633
query77 360 373 302 302
query78 9695 9707 9128 9128
query79 970 888 531 531
query80 518 423 339 339
query81 529 317 279 279
query82 701 138 116 116
query83 303 206 186 186
query84 310 117 107 107
query85 811 428 371 371
query86 314 235 231 231
query87 2009 1961 1829 1829
query88 3627 2769 2716 2716
query89 337 304 263 263
query90 1901 188 186 186
query91 163 153 132 132
query92 101 93 90 90
query93 1015 984 581 581
query94 460 305 288 288
query95 602 358 327 327
query96 691 521 232 232
query97 2478 2436 2323 2323
query98 163 173 151 151
query99 781 768 668 668
Total cold run time: 234884 ms
Total hot run time: 153223 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6190432359
<details>
<summary>TPC-H: <b>Total hot run time: 29557 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 405e8abb3212063b297bb63400ccb0a135577d4d, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17604 5577 5523 5523
q2 2098 297 262 262
q3 10238 1414 866 866
q4 4678 473 350 350
q5 7427 786 536 536
q6 190 189 163 163
q7 774 820 632 632
q8 9272 1358 1135 1135
q9 5597 4303 4269 4269
q10 6825 1335 1029 1029
q11 438 261 257 257
q12 654 397 304 304
q13 18062 3686 3067 3067
q14 279 274 256 256
q15 q16 740 732 681 681
q17 1198 751 586 586
q18 7259 6260 6197 6197
q19 1132 958 612 612
q20 404 354 234 234
q21 5182 2327 2463 2327
q22 370 328 271 271
Total cold run time: 100421 ms
Total hot run time: 29557 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6186 6300 6131 6131
q2 685 583 572 572
q3 5259 5391 4980 4980
q4 2005 2147 1635 1635
q5 5299 5602 5934 5602
q6 256 197 158 158
q7 2382 2125 1947 1947
q8 3311 3008 2807 2807
q9 8260 8173 8202 8173
q10 3791 3687 3324 3324
q11 640 459 410 410
q12 695 751 523 523
q13 3529 3776 3397 3397
q14 319 310 279 279
q15 q16 732 759 665 665
q17 8401 7539 7426 7426
q18 13189 12410 13088 12410
q19 911 787 796 787
q20 2183 2165 1928 1928
q21 5874 4802 4960 4802
q22 496 469 402 402
Total cold run time: 74403 ms
Total hot run time: 68358 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6188289347
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6188797985
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6196510177
<details>
<summary>ClickBench: <b>Total hot run time: 24.48 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 235def26618e0b31905de046c280a8c565238292, data reload: false
query1 0.00 0.00 0.00
query2 0.10 0.06 0.05
query3 0.27 0.12 0.11
query4 1.62 0.12 0.12
query5 0.28 0.24 0.24
query6 1.16 0.69 0.68
query7 0.04 0.01 0.01
query8 0.06 0.04 0.03
query9 0.40 0.34 0.34
query10 0.58 0.57 0.57
query11 0.21 0.14 0.14
query12 0.20 0.15 0.14
query13 0.49 0.48 0.48
query14 1.02 1.01 1.02
query15 0.62 0.60 0.60
query16 0.34 0.34 0.35
query17 1.16 1.11 1.14
query18 0.22 0.20 0.21
query19 2.09 1.95 1.97
query20 0.02 0.01 0.01
query21 15.50 0.27 0.14
query22 4.46 0.05 0.06
query23 16.25 0.33 0.12
query24 3.08 0.59 0.41
query25 0.12 0.07 0.04
query26 1.02 0.24 0.15
query27 0.06 0.04 0.03
query28 2.07 0.60 0.40
query29 12.54 4.20 3.34
query30 0.28 0.13 0.14
query31 2.78 0.58 0.32
query32 3.23 0.61 0.52
query33 3.07 3.20 3.23
query34 15.42 4.02 3.36
query35 3.35 3.37 3.36
query36 0.56 0.46 0.41
query37 0.09 0.07 0.06
query38 0.05 0.04 0.04
query39 0.03 0.03 0.03
query40 0.16 0.15 0.15
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 95.16 s
Total hot run time: 24.48 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #69120:
URL: https://github.com/apache/doris/pull/69120#discussion_r4281085831
##########
be/src/core/column/column_vector.h:
##########
@@ -413,7 +413,13 @@ class ColumnVector final : public COWHelper<IColumn, ColumnVector<T>> {
// when run function which need_replace_null_data_to_default, use the value far from 0 to avoid
// raise errors for null cell.
static value_type default_value() {
- if constexpr (is_date_type(T) || T == PrimitiveType::TYPE_TIMESTAMPTZ) {
+ if constexpr (T == PrimitiveType::TYPE_DATE) {
+ return PrimitiveTypeTraits<T>::CppType::DATE_DEFAULT_VALUE;
+ } else if constexpr (T == PrimitiveType::TYPE_DATETIME) {
+ return PrimitiveTypeTraits<T>::CppType::DATETIME_DEFAULT_VALUE;
Review Comment:
[P1] Preserve legacy temporal NULL shuffle hashes during upgrades
These defaults also feed `ColumnVector::update_crc32c_batch_default_on_null()` through `ColumnNullable::update_crc32c_batch()`. Previously the invalid tag made `to_buffer()` return zero bytes for a NULL DATE/DATETIME; the corrected defaults now hash `1970-01-01` or `1970-01-01 00:00:00`. `Crc32CHashPartitioner` uses that hash for remote exchanges when `enable_new_shuffle_hash_method=true` (the default), with no version gate. With four reducers, the old NULL hash maps to channel 0 and either new hash maps to channel 2. During a rolling upgrade, a distributed `SELECT d, COUNT(*) FROM t GROUP BY d` on nullable legacy DATE/DATETIME can therefore return two NULL groups with partial counts. Keep the valid execution defaults, but preserve the legacy NULL hash separately or negotiate the hash semantics for the whole query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6190706120
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6195539092
# BE UT Coverage Report
Increment line coverage `75.00% (6/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/235def26618e0b31905de046c280a8c565238292_235def26618e0b31905de046c280a8c565238292/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/235def26618e0b31905de046c280a8c565238292_235def26618e0b31905de046c280a8c565238292/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 66.23% (31704/47871) |
| Line Coverage | 51.06% (335266/656566) |
| Region Coverage | 46.36% (270841/584214) |
| Branch Coverage | 48.00% (127290/265179) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6195620696
# BE Regression && UT Coverage Report
Increment line coverage `75.00% (6/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69120_235def26618e0b31905de046c280a8c565238292_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69120_235def26618e0b31905de046c280a8c565238292_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.99% (35671/46332) |
| Line Coverage | 62.30% (404421/649151) |
| Region Coverage | 58.62% (341022/581748) |
| Branch Coverage | 59.59% (157512/264346) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6210626035
https://github.com/apache/doris/pull/19077/changes since doris 2.0.0 alpha datev1 and decimalv2 are prohibted by default. So this modification only has a little affect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6186176361
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6196412805
<details>
<summary>TPC-DS: <b>Total hot run time: 152371 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 235def26618e0b31905de046c280a8c565238292, data reload: false
query5 4306 614 462 462
query6 429 208 193 193
query7 4803 445 236 236
query8 319 174 154 154
query9 8747 4044 4023 4023
query10 468 321 280 280
query11 6070 3788 3545 3545
query12 148 94 86 86
query13 1258 451 324 324
query14 6075 4034 3694 3694
query14_1 3505 3513 3541 3513
query15 210 199 176 176
query16 944 450 437 437
query17 863 646 542 542
query18 2425 423 313 313
query19 200 173 147 147
query20 86 83 85 83
query21 207 138 114 114
query22 12976 12994 12875 12875
query23 13563 12840 12436 12436
query23_1 12578 12534 12567 12534
query24 7114 859 467 467
query24_1 478 489 491 489
query25 547 392 343 343
query26 1299 253 138 138
query27 2775 432 271 271
query28 4595 1972 1976 1972
query29 1587 595 433 433
query30 302 222 182 182
query31 1012 923 804 804
query32 157 92 93 92
query33 512 292 235 235
query34 879 838 507 507
query35 746 754 634 634
query36 805 860 710 710
query37 130 93 91 91
query38 1803 1729 1712 1712
query39 813 800 753 753
query39_1 721 721 746 721
query40 206 114 93 93
query41 67 62 67 62
query42 84 83 81 81
query43 364 392 330 330
query44 1283 702 704 702
query45 182 180 162 162
query46 894 952 566 566
query47 3021 2954 2821 2821
query48 291 316 219 219
query49 579 400 296 296
query50 667 283 215 215
query51 10625 10441 10539 10441
query52 78 78 75 75
query53 184 207 151 151
query54 245 201 180 180
query55 71 72 66 66
query56 230 214 225 214
query57 1632 1567 1569 1567
query58 286 260 255 255
query59 2043 2108 1886 1886
query60 288 246 225 225
query61 146 140 148 140
query62 391 340 284 284
query63 211 166 168 166
query64 2725 947 776 776
query65 3309 3250 3270 3250
query66 1775 427 297 297
query67 20255 20018 20132 20018
query68 2956 994 629 629
query69 385 291 256 256
query70 865 785 775 775
query71 296 232 209 209
query72 2807 2684 2426 2426
query73 518 539 304 304
query74 4596 4452 4325 4325
query75 2352 2303 1946 1946
query76 2304 1022 614 614
query77 363 390 290 290
query78 9757 9666 9164 9164
query79 1014 876 530 530
query80 752 420 339 339
query81 572 327 271 271
query82 858 133 117 117
query83 310 193 182 182
query84 328 119 102 102
query85 867 427 377 377
query86 357 237 232 232
query87 2006 1958 1816 1816
query88 3691 2744 2724 2724
query89 342 295 254 254
query90 1838 189 181 181
query91 167 154 125 125
query92 103 89 91 89
query93 990 993 574 574
query94 506 305 273 273
query95 599 407 327 327
query96 663 524 242 242
query97 2460 2411 2325 2325
query98 163 152 144 144
query99 784 755 642 642
Total cold run time: 234946 ms
Total hot run time: 152371 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6190601848
<details>
<summary>TPC-DS: <b>Total hot run time: 152438 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 405e8abb3212063b297bb63400ccb0a135577d4d, data reload: false
query5 4299 596 488 488
query6 427 208 190 190
query7 4805 449 232 232
query8 319 169 170 169
query9 8761 4030 4041 4030
query10 478 309 259 259
query11 6003 3813 3524 3524
query12 148 92 86 86
query13 1266 458 321 321
query14 6030 4125 3807 3807
query14_1 3532 3581 3609 3581
query15 208 196 181 181
query16 946 472 432 432
query17 866 660 547 547
query18 2429 426 324 324
query19 195 162 136 136
query20 87 87 85 85
query21 206 141 115 115
query22 13041 13032 12856 12856
query23 13500 12922 12434 12434
query23_1 12625 12500 12581 12500
query24 7103 824 462 462
query24_1 479 482 478 478
query25 540 427 369 369
query26 1341 264 145 145
query27 2746 437 279 279
query28 4600 1968 1985 1968
query29 1628 582 446 446
query30 301 223 181 181
query31 1016 924 813 813
query32 138 87 89 87
query33 520 293 240 240
query34 899 916 523 523
query35 761 775 641 641
query36 823 807 718 718
query37 138 97 95 95
query38 1799 1743 1674 1674
query39 797 805 756 756
query39_1 745 732 747 732
query40 207 110 92 92
query41 66 62 64 62
query42 88 86 83 83
query43 394 386 324 324
query44 1300 702 713 702
query45 184 177 164 164
query46 853 954 580 580
query47 2938 2936 2832 2832
query48 299 306 222 222
query49 572 398 303 303
query50 671 302 223 223
query51 10552 10726 10405 10405
query52 78 89 71 71
query53 190 209 153 153
query54 230 205 189 189
query55 73 69 68 68
query56 263 225 214 214
query57 1628 1563 1535 1535
query58 287 263 241 241
query59 2153 2160 1957 1957
query60 292 246 225 225
query61 146 141 149 141
query62 390 339 290 290
query63 196 164 165 164
query64 2698 940 767 767
query65 3310 3254 3267 3254
query66 1778 409 300 300
query67 20386 20096 19948 19948
query68 2951 998 614 614
query69 381 269 244 244
query70 867 796 790 790
query71 300 227 208 208
query72 2700 2612 2321 2321
query73 516 524 297 297
query74 4643 4491 4342 4342
query75 2360 2307 1934 1934
query76 2304 1036 623 623
query77 346 379 289 289
query78 9743 9658 9112 9112
query79 985 860 532 532
query80 560 449 371 371
query81 542 317 274 274
query82 820 144 117 117
query83 314 211 190 190
query84 330 135 115 115
query85 895 432 373 373
query86 324 234 234 234
query87 2011 1977 1811 1811
query88 3605 2739 2710 2710
query89 343 293 263 263
query90 1905 187 178 178
query91 166 161 124 124
query92 99 89 81 81
query93 1005 991 595 595
query94 451 313 288 288
query95 602 407 325 325
query96 662 522 243 243
query97 2463 2451 2308 2308
query98 158 152 154 152
query99 784 776 649 649
Total cold run time: 234515 ms
Total hot run time: 152438 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6192011530
<details>
<summary>TPC-H: <b>Total hot run time: 29858 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 235def26618e0b31905de046c280a8c565238292, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17599 5663 5563 5563
q2 2132 320 281 281
q3 10191 1403 856 856
q4 4685 470 342 342
q5 7437 800 554 554
q6 189 186 161 161
q7 779 808 625 625
q8 9258 1400 1051 1051
q9 5914 4300 4296 4296
q10 6814 1313 1022 1022
q11 445 260 237 237
q12 627 404 286 286
q13 18116 3618 3018 3018
q14 276 275 253 253
q15 q16 749 737 684 684
q17 1251 766 611 611
q18 7194 6288 6215 6215
q19 1129 983 630 630
q20 405 338 240 240
q21 5888 2626 2639 2626
q22 415 387 307 307
Total cold run time: 101493 ms
Total hot run time: 29858 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6661 6703 6748 6703
q2 750 594 561 561
q3 5546 5777 5383 5383
q4 2110 2154 1552 1552
q5 5728 5563 5820 5563
q6 241 197 144 144
q7 2269 2025 1818 1818
q8 3208 2808 2818 2808
q9 8061 8012 7852 7852
q10 3652 3595 3256 3256
q11 605 402 373 373
q12 647 687 498 498
q13 3246 3562 3004 3004
q14 287 291 262 262
q15 q16 668 685 615 615
q17 7776 7023 6882 6882
q18 13121 12274 13036 12274
q19 923 787 825 787
q20 2184 2190 1929 1929
q21 5792 4768 4868 4768
q22 504 473 406 406
Total cold run time: 73979 ms
Total hot run time: 67438 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6196209014
<details>
<summary>TPC-H: <b>Total hot run time: 29325 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 235def26618e0b31905de046c280a8c565238292, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17585 5611 5507 5507
q2 2101 325 276 276
q3 10215 1442 853 853
q4 4687 474 345 345
q5 7446 803 545 545
q6 191 182 160 160
q7 776 802 613 613
q8 9265 1339 1126 1126
q9 5607 4283 4240 4240
q10 6808 1298 1019 1019
q11 432 258 238 238
q12 627 408 291 291
q13 18090 3652 3043 3043
q14 284 274 250 250
q15 q16 744 730 667 667
q17 1209 750 577 577
q18 7183 6279 6213 6213
q19 1259 970 605 605
q20 382 335 226 226
q21 5176 2269 2439 2269
q22 380 316 262 262
Total cold run time: 100447 ms
Total hot run time: 29325 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6159 6091 6067 6067
q2 694 570 525 525
q3 5221 5397 4924 4924
q4 1996 2146 1542 1542
q5 5260 5481 6017 5481
q6 255 207 158 158
q7 2323 2076 1890 1890
q8 3272 3060 2831 2831
q9 8200 8080 8157 8080
q10 3788 3686 3315 3315
q11 622 423 412 412
q12 691 715 504 504
q13 3462 3787 3411 3411
q14 314 315 284 284
q15 q16 719 745 691 691
q17 8343 7608 7219 7219
q18 13161 12313 13120 12313
q19 907 783 781 781
q20 2211 2151 1929 1929
q21 5809 4741 4779 4741
q22 508 442 396 396
Total cold run time: 73915 ms
Total hot run time: 67494 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #69120:
URL: https://github.com/apache/doris/pull/69120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6190688564
<details>
<summary>ClickBench: <b>Total hot run time: 24.69 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 405e8abb3212063b297bb63400ccb0a135577d4d, data reload: false
query1 0.01 0.01 0.01
query2 0.09 0.05 0.05
query3 0.27 0.12 0.12
query4 1.61 0.12 0.12
query5 0.27 0.26 0.26
query6 1.17 0.69 0.69
query7 0.05 0.01 0.01
query8 0.06 0.04 0.04
query9 0.40 0.34 0.36
query10 0.57 0.57 0.57
query11 0.20 0.14 0.13
query12 0.20 0.15 0.15
query13 0.50 0.49 0.50
query14 1.03 0.99 1.00
query15 0.63 0.60 0.61
query16 0.34 0.36 0.35
query17 1.14 1.10 1.17
query18 0.22 0.20 0.20
query19 2.15 2.03 1.98
query20 0.02 0.02 0.01
query21 15.51 0.27 0.15
query22 4.48 0.06 0.05
query23 16.33 0.34 0.12
query24 3.09 0.66 0.40
query25 0.10 0.07 0.05
query26 1.31 0.26 0.15
query27 0.03 0.04 0.04
query28 1.83 0.62 0.43
query29 12.50 4.23 3.39
query30 0.28 0.14 0.12
query31 2.77 0.56 0.34
query32 3.24 0.62 0.52
query33 3.14 3.20 3.20
query34 15.42 4.03 3.40
query35 3.38 3.31 3.36
query36 0.54 0.45 0.46
query37 0.10 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.03 0.03
query40 0.18 0.15 0.14
query41 0.08 0.03 0.03
query42 0.03 0.04 0.03
query43 0.04 0.03 0.03
Total cold run time: 95.39 s
Total hot run time: 24.69 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on code in PR #69120:
URL: https://github.com/apache/doris/pull/69120#discussion_r4282240956
##########
be/src/core/column/column_vector.h:
##########
@@ -413,7 +413,13 @@ class ColumnVector final : public COWHelper<IColumn, ColumnVector<T>> {
// when run function which need_replace_null_data_to_default, use the value far from 0 to avoid
// raise errors for null cell.
static value_type default_value() {
- if constexpr (is_date_type(T) || T == PrimitiveType::TYPE_TIMESTAMPTZ) {
+ if constexpr (T == PrimitiveType::TYPE_DATE) {
+ return PrimitiveTypeTraits<T>::CppType::DATE_DEFAULT_VALUE;
+ } else if constexpr (T == PrimitiveType::TYPE_DATETIME) {
+ return PrimitiveTypeTraits<T>::CppType::DATETIME_DEFAULT_VALUE;
Review Comment:
先不管升降机
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Preserve valid types for date defaults [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #69120:
URL: https://github.com/apache/doris/pull/69120#issuecomment-6190704117
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org