You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/12 08:06:24 UTC
[GitHub] [pulsar] yangl opened a new pull request #10551: Fix ack receipt version support logic
yangl opened a new pull request #10551:
URL: https://github.com/apache/pulsar/pull/10551
### Motivation
```
if (conf.isAckReceiptEnabled() &&
Commands.peerSupportsAckReceipt(clientCnx.getRemoteEndpointProtocolVersion())) {
log.warn("Server don't support ack for receipt! " +
"ProtoVersion >=17 support! nowVersion : {}", clientCnx.getRemoteEndpointProtocolVersion());
}
```
the ack receipt version support logic `Commands.peerSupportsAckReceipt(clientCnx.getRemoteEndpointProtocolVersion())` should add not.
### Modifications
add not `!Commands.peerSupportsAckReceipt(clientCnx.getRemoteEndpointProtocolVersion()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #10551: Fix ack receipt version support logic
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10551:
URL: https://github.com/apache/pulsar/pull/10551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #10551: Fix ack receipt version support logic
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10551:
URL: https://github.com/apache/pulsar/pull/10551#issuecomment-868995816
We don't have ack receipt in branch-2.7, so don't need to cherry-pick this fix to branch-2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org