You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/03/04 08:33:21 UTC

[jira] [Commented] (ISIS-729) Provide facet factory to treat all actions by default as commands, unless explicitly opted out

    [ https://issues.apache.org/jira/browse/ISIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919093#comment-13919093 ] 

ASF subversion and git services commented on ISIS-729:
------------------------------------------------------

Commit 9543f0a06d0a191bcb8598481c81474936ed4d35 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9543f0a ]

ISIS-728, ISIS-729: config-based audit and commands

In detail:
- @Command and @Audited now have disabled flag
- new CommandFromConfigurationFacetFactory and CommandFacetFromConfiguration
- new AuditableFromConfigurationFacetFactory and AuditableFacetFromConfiguration
- in ActionInvocationFacetViaMethod, check that command is not disabled
- in IsisTransaction, check that auditable facet is not disabled

Also:
- renamed existing facet factory and facet for @Auditable annotation, added unit test
- added pngs for audit entry, command, published event
- new JDOQL queries for commands, available in CommandServiceJdoRepository#findByFromAndTo
- new JDOQL queries for audit entries available in AuditingServiceJdoRepository#findByFromAndTo
- new JDOQL queries for published events, available in PublishingServiceJdoRepository#findByFromAndTo
- recentChanges contributed action now includes published events
- listAll() removed from BackgroundCommandServiceJdoRepository
- updates to todo app to expose new JDOQL queries in Admin menu
- updated some icons in example todo app


> Provide facet factory to treat all actions by default as commands, unless explicitly opted out
> ----------------------------------------------------------------------------------------------
>
>                 Key: ISIS-729
>                 URL: https://issues.apache.org/jira/browse/ISIS-729
>             Project: Isis
>          Issue Type: New Feature
>          Components: Core, Objectstore: JDO
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: objectstore-jdo-1.4.0, core-1.4.0
>
>
> Opting out through:  @Command(disabled=false)
> Also:
> - can restrict to just non-safe (non-query only actions)
> - if the CommandFacet is already present, then that should take precedence
> - any implementation of HasTransactionId (command, audit entry or published event) should *never* have auditing automatically enabled.
> - require ActionSemanticsFacet to be available in case specified non-query only actions should be ignored
> Enable using isis.properties:
> #isis.services.command.actions=all|none|ignoreQueryOnly



--
This message was sent by Atlassian JIRA
(v6.2#6252)