thrift work

[Greg Stein <gs...@gmail.com>]

Hey all,

I'm looking at Thrift now, with the intent of creating C bindings for
it (for eventual use in Subversion).

I'd also be happy to do a bunch of the other work that is necessary to
turn this into an Apache project. I note that none of the files have
switched over to the proper ASF headers (!!!). I've run into a number
of other out-of-date references to the facebook URLs and the old
license and other stuff like that.

Cheers,
-g

Re: thrift work

[Jérémie BORDIER <ah...@gmail.com>]

On Tue, Jan 27, 2009 at 11:45 PM, Bryan Duxbury <br...@rapleaf.com> wrote:
> The header thing bothers me, too. I think there's already an issue open, but
> we should take action on this one soon. Feel free to submit a patch if you
> can find the issue in Jira, or open one if you can't find it.
>
> -Bryan
>
> On Jan 27, 2009, at 2:37 PM, Greg Stein wrote:
>
>> Hey all,
>>
>> I'm looking at Thrift now, with the intent of creating C bindings for
>> it (for eventual use in Subversion).
>>
>> I'd also be happy to do a bunch of the other work that is necessary to
>> turn this into an Apache project. I note that none of the files have
>> switched over to the proper ASF headers (!!!). I've run into a number
>> of other out-of-date references to the facebook URLs and the old
>> license and other stuff like that.
>>
>> Cheers,
>> -g
>
>

Here's the Jira issue for the C++ library / compiler. This issue is
already fixed for Java if i remember right.
https://issues.apache.org/jira/browse/THRIFT-270

Cheers,
Jérémie

-- 
Jérémie 'ahFeel' BORDIER

Re: thrift work

[Bryan Duxbury <br...@rapleaf.com>]

The header thing bothers me, too. I think there's already an issue  
open, but we should take action on this one soon. Feel free to submit  
a patch if you can find the issue in Jira, or open one if you can't  
find it.

-Bryan

On Jan 27, 2009, at 2:37 PM, Greg Stein wrote:

> Hey all,
>
> I'm looking at Thrift now, with the intent of creating C bindings for
> it (for eventual use in Subversion).
>
> I'd also be happy to do a bunch of the other work that is necessary to
> turn this into an Apache project. I note that none of the files have
> switched over to the proper ASF headers (!!!). I've run into a number
> of other out-of-date references to the facebook URLs and the old
> license and other stuff like that.
>
> Cheers,
> -g

Re: thrift work

[David Reiss <dr...@facebook.com>]

You can download a tarball from gitweb:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=snapshot;h=refs/heads/pri/rmcfarland/c_bindings_linear;sf=tgz

github has this feature too, but it appears to be broken at the moment.

--David

Greg Stein wrote:
> Hey Ross,
> 
> Do you have a handy tarball of your work? I'm interested in picking up
> work on the C bindings, and it would be great to start with your work.
> 
> Thanks,
> -g
> 
> On Wed, Jan 28, 2009 at 13:43, Jake Luciani <ja...@gmail.com> wrote:
>> Ross McFarland had contributed c-bindings a while back (based on glib)
>>
>> http://thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/rmcfarland/c_bindings_linear
>>
>> I think they are client side only.
>>
>> -Jake
>>
>> On Tue, Jan 27, 2009 at 5:37 PM, Greg Stein <gs...@gmail.com> wrote:
>>> Hey all,
>>>
>>> I'm looking at Thrift now, with the intent of creating C bindings for
>>> it (for eventual use in Subversion).
>>>
>>> I'd also be happy to do a bunch of the other work that is necessary to
>>> turn this into an Apache project. I note that none of the files have
>>> switched over to the proper ASF headers (!!!). I've run into a number
>>> of other out-of-date references to the facebook URLs and the old
>>> license and other stuff like that.
>>>
>>> Cheers,
>>> -g
>>>

Re: thrift work

[Greg Stein <gs...@gmail.com>]

Hey Ross,

Do you have a handy tarball of your work? I'm interested in picking up
work on the C bindings, and it would be great to start with your work.

Thanks,
-g

On Wed, Jan 28, 2009 at 13:43, Jake Luciani <ja...@gmail.com> wrote:
> Ross McFarland had contributed c-bindings a while back (based on glib)
>
> http://thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/rmcfarland/c_bindings_linear
>
> I think they are client side only.
>
> -Jake
>
> On Tue, Jan 27, 2009 at 5:37 PM, Greg Stein <gs...@gmail.com> wrote:
>> Hey all,
>>
>> I'm looking at Thrift now, with the intent of creating C bindings for
>> it (for eventual use in Subversion).
>>
>> I'd also be happy to do a bunch of the other work that is necessary to
>> turn this into an Apache project. I note that none of the files have
>> switched over to the proper ASF headers (!!!). I've run into a number
>> of other out-of-date references to the facebook URLs and the old
>> license and other stuff like that.
>>
>> Cheers,
>> -g
>>
>

Re: thrift work

[Michael Greene <mi...@gmail.com>]

Just to reinforce this point with a concrete reason, the recent
security problem with gitweb made several of the git-hosted patches
inaccessible from JIRA using the posted links, with no patches stored
in JIRA.  Although I enjoy access to the git repository, I don't think
the "Patch Available" field should be set unless a patch is available
in JIRA.

Michael

On Wed, Jan 28, 2009 at 1:39 PM, Mark Slee <ms...@facebook.com> wrote:
> These should definitely also be posted to JIRA so that they're accessible to everyone interested in the project, but just wanted to shed some light on that.

RE: thrift work

[Mark Slee <ms...@facebook.com>]

Hmm, there should be a JIRA ticket and/or category open for the C bindings. But it's looking like maybe there's not and I can't find one right now.

Generally though, we haven't been granting committer priveleges until after people have contributed some significant patches to the project (using JIRA as the main channel for open communication etc.) and established some level of expertise and commitment to the Thrift code.

To the SVN point, while we do follow the standard Apache practices of posting all patches etc. to JIRA and using SVN as our repository, it seems a lot of the individual developers on the project prefer to use git in their development environment. Hence a lot of people end up sharing links to their openly hosted repositories.

These should definitely also be posted to JIRA so that they're accessible to everyone interested in the project, but just wanted to shed some light on that.

Cheers,
Mark

-----Original Message-----
From: Greg Stein [mailto:gstein@gmail.com] 
Sent: Wednesday, January 28, 2009 5:10 AM
To: thrift-dev@incubator.apache.org
Subject: Re: thrift work

Hunh. Ross should have got commit privs so he could work on those in the central SVN repository...

On Wed, Jan 28, 2009 at 13:43, Jake Luciani <ja...@gmail.com> wrote:
> Ross McFarland had contributed c-bindings a while back (based on glib)
>
> http://thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/rmcfar
> land/c_bindings_linear
>
> I think they are client side only.
>
> -Jake
>
> On Tue, Jan 27, 2009 at 5:37 PM, Greg Stein <gs...@gmail.com> wrote:
>> Hey all,
>>
>> I'm looking at Thrift now, with the intent of creating C bindings for 
>> it (for eventual use in Subversion).
>>
>> I'd also be happy to do a bunch of the other work that is necessary 
>> to turn this into an Apache project. I note that none of the files 
>> have switched over to the proper ASF headers (!!!). I've run into a 
>> number of other out-of-date references to the facebook URLs and the 
>> old license and other stuff like that.
>>
>> Cheers,
>> -g
>>
>

Re: thrift work

[Greg Stein <gs...@gmail.com>]

Hunh. Ross should have got commit privs so he could work on those in
the central SVN repository...

On Wed, Jan 28, 2009 at 13:43, Jake Luciani <ja...@gmail.com> wrote:
> Ross McFarland had contributed c-bindings a while back (based on glib)
>
> http://thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/rmcfarland/c_bindings_linear
>
> I think they are client side only.
>
> -Jake
>
> On Tue, Jan 27, 2009 at 5:37 PM, Greg Stein <gs...@gmail.com> wrote:
>> Hey all,
>>
>> I'm looking at Thrift now, with the intent of creating C bindings for
>> it (for eventual use in Subversion).
>>
>> I'd also be happy to do a bunch of the other work that is necessary to
>> turn this into an Apache project. I note that none of the files have
>> switched over to the proper ASF headers (!!!). I've run into a number
>> of other out-of-date references to the facebook URLs and the old
>> license and other stuff like that.
>>
>> Cheers,
>> -g
>>
>

Re: thrift work

[Jake Luciani <ja...@gmail.com>]

Ross McFarland had contributed c-bindings a while back (based on glib)

http://thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/rmcfarland/c_bindings_linear

I think they are client side only.

-Jake

On Tue, Jan 27, 2009 at 5:37 PM, Greg Stein <gs...@gmail.com> wrote:
> Hey all,
>
> I'm looking at Thrift now, with the intent of creating C bindings for
> it (for eventual use in Subversion).
>
> I'd also be happy to do a bunch of the other work that is necessary to
> turn this into an Apache project. I note that none of the files have
> switched over to the proper ASF headers (!!!). I've run into a number
> of other out-of-date references to the facebook URLs and the old
> license and other stuff like that.
>
> Cheers,
> -g
>