You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/12/05 07:14:51 UTC
[kudu-CR] small cleanup: remove unnecessary semicolons (part 3)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14847
Change subject: small cleanup: remove unnecessary semicolons (part 3)
......................................................................
small cleanup: remove unnecessary semicolons (part 3)
The motivation for this change was seeing a few warnings generated by
the built-in static analysis tools while browsing the code in QtCreator.
This patch does not contain any functional changes.
Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
---
M src/kudu/util/env_posix.cc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14847/1
--
To view, visit http://gerrit.cloudera.org:8080/14847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Gerrit-Change-Number: 14847
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] small cleanup: remove unnecessary semicolons (part 3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14847 )
Change subject: small cleanup: remove unnecessary semicolons (part 3)
......................................................................
small cleanup: remove unnecessary semicolons (part 3)
The motivation for this change was seeing a few warnings generated by
the built-in static analysis tools while browsing the code in QtCreator.
This patch does not contain any functional changes.
Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Reviewed-on: http://gerrit.cloudera.org:8080/14847
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/env_posix.cc
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Gerrit-Change-Number: 14847
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] small cleanup: remove unnecessary semicolons (part 3)
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14847 )
Change subject: small cleanup: remove unnecessary semicolons (part 3)
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Gerrit-Change-Number: 14847
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:46:55 +0000
Gerrit-HasComments: No
[kudu-CR] small cleanup: remove unnecessary semicolons (part 3)
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14847 )
Change subject: small cleanup: remove unnecessary semicolons (part 3)
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Gerrit-Change-Number: 14847
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 07:16:38 +0000
Gerrit-HasComments: No
[kudu-CR] small cleanup: remove unnecessary semicolons (part 3)
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14847 )
Change subject: small cleanup: remove unnecessary semicolons (part 3)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Gerrit-Change-Number: 14847
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 18:43:44 +0000
Gerrit-HasComments: No
[kudu-CR] small cleanup: remove unnecessary semicolons (part 3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14847
to look at the new patch set (#2).
Change subject: small cleanup: remove unnecessary semicolons (part 3)
......................................................................
small cleanup: remove unnecessary semicolons (part 3)
The motivation for this change was seeing a few warnings generated by
the built-in static analysis tools while browsing the code in QtCreator.
This patch does not contain any functional changes.
Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
---
M src/kudu/util/env_posix.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14847/2
--
To view, visit http://gerrit.cloudera.org:8080/14847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5b0e9f9f34030e4ede2dc5d2d256d386086b716
Gerrit-Change-Number: 14847
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)