You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/13 13:18:44 UTC

[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #4124: add #undef for some libc function

davids5 edited a comment on pull request #4124:
URL: https://github.com/apache/incubator-nuttx/pull/4124#issuecomment-879080308


   @xiaoxiang781216 - your argument is sound. The implementation is ugly. In the past I know that @patacongo rejected certain kinds of debug code in the codebase.   I think the value far out ways the the ugly-ness. I would ask that you add a readme in the docs that full explains how to use this AND on each of the #undef  add a /* See /<path to readme/> */


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org