You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "taskain7 (via GitHub)" <gi...@apache.org> on 2023/07/21 08:21:43 UTC

[GitHub] [fineract] taskain7 opened a new pull request, #3320: [FINERACT-1760] Client transaction by transaction external ID

taskain7 opened a new pull request, #3320:
URL: https://github.com/apache/fineract/pull/3320

   ## Description
   
    - Pay charge with transaction external ID
    - retrieve client transaction by transaction external ID
    - undo client transaction by transaction external ID
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] taskain7 commented on a diff in pull request #3320: [FINERACT-1760] Client transaction by transaction external ID

Posted by "taskain7 (via GitHub)" <gi...@apache.org>.
taskain7 commented on code in PR #3320:
URL: https://github.com/apache/fineract/pull/3320#discussion_r1270867094


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransaction.java:
##########
@@ -98,24 +99,23 @@ public class ClientTransaction extends AbstractAuditableWithUTCDateTimeCustom {
     protected ClientTransaction() {}
 
     public static ClientTransaction payCharge(final Client client, final Office office, PaymentDetail paymentDetail,
-            final LocalDate transactionDate, final Money amount, final String currencyCode) {
+            final LocalDate transactionDate, final Money amount, final String currencyCode, final ExternalId externalId) {
         final boolean isReversed = false;
-        final String externalId = null;
         return new ClientTransaction(client, office, paymentDetail, ClientTransactionType.PAY_CHARGE.getValue(), transactionDate, amount,
                 isReversed, externalId, currencyCode);
     }
 
     public static ClientTransaction waiver(final Client client, final Office office, final LocalDate transactionDate, final Money amount,
             final String currencyCode) {
         final boolean isReversed = false;
-        final String externalId = null;
+        final ExternalId externalId = null;

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics merged pull request #3320: [FINERACT-1760] Client transaction by transaction external ID

Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics merged PR #3320:
URL: https://github.com/apache/fineract/pull/3320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3320: [FINERACT-1760] Client transaction by transaction external ID

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3320:
URL: https://github.com/apache/fineract/pull/3320#discussion_r1270861845


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransaction.java:
##########
@@ -98,24 +99,23 @@ public class ClientTransaction extends AbstractAuditableWithUTCDateTimeCustom {
     protected ClientTransaction() {}
 
     public static ClientTransaction payCharge(final Client client, final Office office, PaymentDetail paymentDetail,
-            final LocalDate transactionDate, final Money amount, final String currencyCode) {
+            final LocalDate transactionDate, final Money amount, final String currencyCode, final ExternalId externalId) {
         final boolean isReversed = false;
-        final String externalId = null;
         return new ClientTransaction(client, office, paymentDetail, ClientTransactionType.PAY_CHARGE.getValue(), transactionDate, amount,
                 isReversed, externalId, currencyCode);
     }
 
     public static ClientTransaction waiver(final Client client, final Office office, final LocalDate transactionDate, final Money amount,
             final String currencyCode) {
         final boolean isReversed = false;
-        final String externalId = null;
+        final ExternalId externalId = null;

Review Comment:
   ExternalId by design should never be null. Please use ExternalId.empty() in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org