You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/09/30 10:45:49 UTC

[GitHub] [accumulo] cshannon commented on pull request #2985: Removed API method from InstanceOperations that exposed Thrift object

cshannon commented on PR #2985:
URL: https://github.com/apache/accumulo/pull/2985#issuecomment-1263416039

   So the issue here with the [test](https://builds.apache.org/job/Accumulo/job/main/lastCompletedBuild/org.apache.accumulo$accumulo-test/testReport/org.apache.accumulo.test.conf/PropStoreConfigIT/modifyInstancePropertiesTest/) breaking is that the point of the new method that was removed was to only return the system properties but now the assertion is done on getSystemConfiguration() which is going to return the entire config.
   
   Why not just keep the public getSystemProperties() method but have it return a map instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org