You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/09/09 01:33:36 UTC
[GitHub] rdhabalia commented on a change in pull request #751: Broker side deduplication
rdhabalia commented on a change in pull request #751: Broker side deduplication
URL: https://github.com/apache/incubator-pulsar/pull/751#discussion_r137913586
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -564,26 +571,30 @@ private void createPersistentTopic(final String topic, CompletableFuture<Topic>
return;
}
- getManagedLedgerConfig(destinationName).thenAccept(config -> {
+ getTopicConfiguration(destinationName).thenAccept(config -> {
// Once we have the configuration, we can proceed with the async open operation
- managedLedgerFactory.asyncOpen(destinationName.getPersistenceNamingEncoding(), config,
+ managedLedgerFactory.asyncOpen(destinationName.getPersistenceNamingEncoding(), config.getManagedLedgerConfig(),
new OpenLedgerCallback() {
@Override
public void openLedgerComplete(ManagedLedger ledger, Object ctx) {
- PersistentTopic persistentTopic = new PersistentTopic(topic, ledger, BrokerService.this);
+ PersistentTopic persistentTopic = new PersistentTopic(topic, ledger, BrokerService.this,
+ config);
Review comment:
I don't see `PersistentTopicConfiguration` being used in `PersistentTopic`. In that case, we don't need `PersistentTopicConfiguration` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services