You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/06 18:15:55 UTC
[GitHub] [airflow] jedcunningham opened a new pull request, #28168: Drop k8s 1.21 and 1.22 support
jedcunningham opened a new pull request, #28168:
URL: https://github.com/apache/airflow/pull/28168
These versions have reached EOL. Also switch the default version to the oldest to be consistent with python and dbs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28168: Drop k8s 1.21 and 1.22 support
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28168:
URL: https://github.com/apache/airflow/pull/28168#discussion_r1041336763
##########
tests/charts/helm_template_generator.py:
##########
@@ -34,7 +34,7 @@
CHART_DIR = str((Path(__file__).parent / ".." / ".." / "chart").resolve())
-DEFAULT_KUBERNETES_VERSION = "1.24.7"
+DEFAULT_KUBERNETES_VERSION = "1.23.13"
Review Comment:
Why change this?
##########
tests/charts/helm_template_generator.py:
##########
@@ -34,7 +34,7 @@
CHART_DIR = str((Path(__file__).parent / ".." / ".." / "chart").resolve())
-DEFAULT_KUBERNETES_VERSION = "1.24.7"
+DEFAULT_KUBERNETES_VERSION = "1.23.13"
Review Comment:
Why is this downgraded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #28168: Drop k8s 1.21 and 1.22 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #28168:
URL: https://github.com/apache/airflow/pull/28168#discussion_r1041343715
##########
tests/charts/helm_template_generator.py:
##########
@@ -34,7 +34,7 @@
CHART_DIR = str((Path(__file__).parent / ".." / ".." / "chart").resolve())
-DEFAULT_KUBERNETES_VERSION = "1.24.7"
+DEFAULT_KUBERNETES_VERSION = "1.23.13"
Review Comment:
As @jedcunningham explained - to keep it consistent with the approach we have in Python/DBs (lowest version is default).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28168: Drop k8s 1.21 and 1.22 support
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28168:
URL: https://github.com/apache/airflow/pull/28168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org