You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "blackmwk (via GitHub)" <gi...@apache.org> on 2026/05/23 02:07:29 UTC
[PR] Use cargo publish to publish crates [iceberg-rust]
blackmwk opened a new pull request, #2489:
URL: https://github.com/apache/iceberg-rust/pull/2489
## Which issue does this PR close?
- Closes #2488 .
## What changes are included in this PR?
Inspired by #2485 , we add missing crates in publish workflow. But instead of maintaining crates publishing order manually, we switch to use `cargo publish --workspace` to publish crates.
## Are these changes tested?
Ran `cargo publish --workspace --all-features --dry-run --no-verify --allow-dirty` locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Use cargo publish to publish crates [iceberg-rust]
Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on PR #2489:
URL: https://github.com/apache/iceberg-rust/pull/2489#issuecomment-4534346892
> LGTM
>
> Looks like we're adding 2 new crates `iceberg-cache-moka` and `iceberg-catalog-loader`. I see you've added catagory/description/keyword to `iceberg-cache-moka`. Is the `iceberg-catalog-loader` change intentional?
>
> Crate Path In old matrix?
> `iceberg` crates/iceberg/Cargo.toml yes
> `iceberg-storage-opendal` crates/storage/opendal/Cargo.toml yes
> `iceberg-catalog-glue` crates/catalog/glue/Cargo.toml yes
> `iceberg-catalog-hms` crates/catalog/hms/Cargo.toml yes
> `iceberg-catalog-rest` crates/catalog/rest/Cargo.toml yes
> `iceberg-catalog-s3tables` crates/catalog/s3tables/Cargo.toml yes
> `iceberg-catalog-sql` crates/catalog/sql/Cargo.toml yes
> `iceberg-datafusion` crates/integrations/datafusion/Cargo.toml yes
> `iceberg-cache-moka` crates/integrations/cache-moka/Cargo.toml **new**
> `iceberg-catalog-loader` crates/catalog/loader/Cargo.toml **new**
> Nit: Also might be better to add
>
> ```
> [workspace.package]
> publish = false
> ```
>
> to the workspace `Cargo.toml` so all crates are not published by default. This can prevent a new crate from being published accidentally (with the current approach, someone has to remember to set `publish = false`)
Done, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Use cargo publish to publish crates [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2489:
URL: https://github.com/apache/iceberg-rust/pull/2489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org