You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/01/18 16:07:16 UTC
[GitHub] incubator-zeppelin pull request: [WIP] selenium test spark, pyspar...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/654
[WIP] selenium test spark, pyspark and sparkSql
### What is this PR for?
Test functionality of spark, pyspark, sparksql
### What type of PR is it?
Improvement
### Todos
* [x] - Selenium for spark
* [x] - Selenium for pyspark
* [x] - Selenium for sparksql
* [] - refactor with https://github.com/apache/incubator-zeppelin/pull/619
### Is there a relevant Jira issue?
ZEPPELIN-587
### How should this be tested?
On macOS
PATH=~/Applications/Firefox.app/Contents/MacOS/:$PATH CI="" \
mvn -Dtest=org.apache.zeppelin.application.TestSparkParagraph -Denforcer.skip=true \
test -pl zeppelin-server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #654
----
commit 022bf6cf6c3a8ae09f57fe42bc50ae303f02cc04
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-01-18T15:03:09Z
selenium test spark, pyspark and sparkSql
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-181732834
Great!
If any of these fails is there a simple way to know why? I think recently there was one minor UI change and it was somewhat ambiguous when Travis fails. What would you recommend? Should UI test be a separate "build" job in Travis?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179255441
@prabhjyotsingh thanks for taking care of reivew in timely manner!
It looks great, how do you think can it be further improved by `import static HelperKeys` so we get rid of duplicating `HelperKeys` and just keep constants?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179049821
Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185061838
I assume this is not running the tests, but only skipping?
(spark-1.6 build)
https://s3.amazonaws.com/archive.travis-ci.org/jobs/109789223/log.txt
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.integration.SparkParagraphIT
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/travis/build/apache/incubator-zeppelin/zeppelin-zengine/target/lib/zeppelin-interpreter-0.6.0-incubating-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/incubator-zeppelin/zeppelin-zengine/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/incubator-zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.6.0-incubating-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/incubator-zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.361 sec - in org.apache.zeppelin.integration.SparkParagraphIT
Running org.apache.zeppelin.integration.ZeppelinIT
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.zeppelin.integration.ZeppelinIT
Running org.apache.zeppelin.integration.ParagraphActionsIT
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.apache.zeppelin.integration.ParagraphActionsIT
Results :
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179386505
Very nice useage of `Enum` here!
Probably a knit-piking but may be also `SHIFT_ENTER` diserves a place there too?
Looks great to me.
I'm just curious, may be you know, why open parentesys is a key, but closing one seems to be ok inside the string literal?
:+1: for more tests that help improving stability!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-181770768
Sure @felixcheung, this sounds better, have create a new PR https://github.com/apache/incubator-zeppelin/pull/706 for addressing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185429817
cool LGTM. merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179370570
@bzz thank you for the quick review, did the relevant change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185040374
Thanks @felixcheung for the review. Made appropriate changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-184535519
Merged with #706, and https://github.com/apache/incubator-zeppelin/pull/709. CI green.
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179731323
@bzz yes thank you. Did it for `SHIFT_ENTER` as well.
Some javascript associated with ace editor is causing problem with open parenthesis, and other that are defined in HelperKeys, and hence have to use this (OPEN_PARENTHESIS).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-181200695
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: selenium test spark, pyspark and ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185067023
Yes skipping since the env "TEST_SELENIUM" is not set.
Otherwise things like these would have shown up
06:06:10,610 INFO org.apache.zeppelin.AbstractZeppelinIT:47 - Starting sleeping for 1 seconds...
06:06:10,611 INFO org.apache.zeppelin.AbstractZeppelinIT:48 - Caller: org.apache.zeppelin.AbstractZeppelinIT.deleteTestNotebook(AbstractZeppelinIT.java:130)
06:06:11,611 INFO org.apache.zeppelin.AbstractZeppelinIT:56 - Finished.
06:06:11,879 INFO org.apache.zeppelin.AbstractZeppelinIT:47 - Starting sleeping for 0 seconds...
06:06:11,880 INFO org.apache.zeppelin.AbstractZeppelinIT:48 - Caller: org.apache.zeppelin.AbstractZeppelinIT.deleteTestNotebook(AbstractZeppelinIT.java:133)
06:06:11,980 INFO org.apache.zeppelin.AbstractZeppelinIT:56 - Finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---