[kudu-CR] [metrics] Add metrics for participant op time

["Yingchun Lai (Code Review)" <ge...@cloudera.org>]

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21375 )

Change subject: [metrics] Add metrics for participant op time
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21375/1/src/kudu/tablet/ops/participant_op.cc
File src/kudu/tablet/ops/participant_op.cc:

http://gerrit.cloudera.org:8080/#/c/21375/1/src/kudu/tablet/ops/participant_op.cc@280
PS1, Line 280:   auto update_metrics = [this]() {
How about making it as a ScopedCleanup, then you don't need to call it manually in every return.


http://gerrit.cloudera.org:8080/#/c/21375/1/src/kudu/tablet/txn_participant-test.cc
File src/kudu/tablet/txn_participant-test.cc:

http://gerrit.cloudera.org:8080/#/c/21375/1/src/kudu/tablet/txn_participant-test.cc@248
PS1, Line 248: a
nit: an



-- 
To view, visit http://gerrit.cloudera.org:8080/21375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25d4bee27e9ba35925634b61fb518467bb59201
Gerrit-Change-Number: 21375
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2024 02:59:46 +0000
Gerrit-HasComments: Yes