[jira] [Commented] (HADOOP-8351) Add exclude/include file , need restart NN or RM.

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267493#comment-13267493 ] 

Harsh J commented on HADOOP-8351:
---------------------------------

He probably meant adding a new file for include/exclude at runtime (cause it was possibly forgotten before by the operator). I think thats a moderate request and if our current refresh-able methods allow for such a thing, we can grant it (though it does seem dangerous if one were to configure badly (bad perm, etc.) and cause NN to throw up? Tests needed!).
                
> Add exclude/include file , need restart NN or RM.
> -------------------------------------------------
>
>                 Key: HADOOP-8351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8351
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>         Environment: suse
>            Reporter: xieguiming
>
> "yarn.resourcemanager.nodes.include-path" default value is "", if we need add one include file. and we must restart the RM. 
> I suggest that adding one include or exclude file, no need restart the RM. only execute the refresh command.
> NN is the same.
> Modify the HostsFileReader class:
> public HostsFileReader(String inFile, 
>                          String exFile)
> to
>  public HostsFileReader(Configuration conf, 
>                          String NODES_INCLUDE_FILE_PATH,String DEFAULT_NODES_INCLUDE_FILE_PATH,
>                         String NODES_EXCLUDE_FILE_PATH,String DEFAULT_NODES_EXCLUDE_FILE_PATH)
> and thus, we can read the config file dynamic. and no need to restart the NM/NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira