You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/20 12:45:17 UTC
[GitHub] [arrow] kou opened a new issue, #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
kou opened a new issue, #35252:
URL: https://github.com/apache/arrow/issues/35252
### Describe the bug, including details regarding any error messages, version, and platform.
`FindGTestAlt.cmake` uses `-DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}` to check whether found GoogleTest can be used with Apache Arrow C++.
`find_package(Arrow)` also uses `FindGTestAlt.cmake`. Apache Arrow C++ always sets `CMAKE_CXX_STANDARD`. So `-DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}` has no problem. But a project that uses `find_package(Arrow)` may not set `CMAKE_CXX_STANDARD`. In this case, `try_compile()` is failed with the following message:
```text
The CXX_STANDARD property on target "cmTC_ce38e" contained an invalid
value: "".
```
* GoogleTest is used by `ArrowTesting` not `Arrow`. So we should put it to `ArrowTesting/`.
* `CMAKE_CXX_STANDARD` check is needed only when Apache Arrow C++ finds GoogleTest. It's not needed when `find_package(Arrow)` because suitable GoogleTest should be found by `find_package(GTestAlot)`.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #35252:
URL: https://github.com/apache/arrow/issues/35252#issuecomment-1516276881
Thanks @kou 😢
Was there any specific job failure that reproduced the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35252:
URL: https://github.com/apache/arrow/issues/35252#issuecomment-1516271777
@raulcd Sorry... One more blocker for 12.0.0...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35252:
URL: https://github.com/apache/arrow/issues/35252#issuecomment-1516287826
Preconditions for this:
* Apache Arrow C++ is built with `-DARROW_BUILD_TESTS=ON`.
* Apache Arrow C++ uses system GoogleTest.
* A project that uses Apache Arrow C++ doesn't set `CMAKE_CXX_STANDARD`. (Workaround: Explicit `set(CMAKE_CXX_STANDARD 17)`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35252:
URL: https://github.com/apache/arrow/issues/35252#issuecomment-1517078979
@raulcd Merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35252:
URL: https://github.com/apache/arrow/issues/35252#issuecomment-1516282240
It doesn't exist in apache/arrow yet.
But if we release 12.0.0 without a fix for this, apache/arrow-flight-sql-postgresql will be failed to build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #35252: [C++] find_package(Arrow) may be failed without CMAKE_CXX_STANDARD project
URL: https://github.com/apache/arrow/issues/35252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org