You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2026/05/05 17:51:12 UTC

(maven) branch graph-align created (now 0b4ed681b2)

This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a change to branch graph-align
in repository https://gitbox.apache.org/repos/asf/maven.git


      at 0b4ed681b2 improve align in dependency graph

This branch includes the following new commits:

     new 0b4ed681b2 improve align in dependency graph

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(maven) 01/01: improve align in dependency graph

Posted by hb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch graph-align
in repository https://gitbox.apache.org/repos/asf/maven.git

commit 0b4ed681b2bdd5b4373d1b2ffed80e67894345ad
Author: Hervé Boutemy <hb...@apache.org>
AuthorDate: Tue May 5 19:50:57 2026 +0200

    improve align in dependency graph
---
 src/graph/ReactorGraph.java | 57 +++++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 28 deletions(-)

diff --git a/src/graph/ReactorGraph.java b/src/graph/ReactorGraph.java
index 8a8dce6eb7..57daef3f64 100755
--- a/src/graph/ReactorGraph.java
+++ b/src/graph/ReactorGraph.java
@@ -144,7 +144,7 @@ public static void main(String[] args) {
             Files.write(Paths.get("target/graph/intermediary_graph.dot"), dotContent.getBytes());
             System.out.println("Intermediary graph written to intermediary_graph.dot");
 
-            // Render graph to SVF
+            // Render graph to SVG
             Graphviz.fromGraph(clusteredGraph)
                     .engine(Engine.FDP)
                     .render(Format.SVG).toFile(new File("target/graph/intermediary_graph.svg"));
@@ -185,40 +185,30 @@ private static MutableGraph generateHighLevelGraph(MutableGraph clusteredGraph,
             MutableGraph cluster = entry.getValue();
 
             String headerColor = clusterName.startsWith("Maven") ? "black" : "#808080";  // #808080 is a middle gray
+            String prefix;
+            switch (clusterName) {
+                case "MavenAPI": prefix = "../api/"; break;
+                case "MavenImplementation": prefix = "../impl/"; break;
+                case "MavenCompatibility": prefix = "../compat/"; break;
+                case "MavenResolver": prefix = "https://maven.apache.org/resolver/"; break;
+                default: prefix = null;
+            }
+
             StringBuilder labelBuilder = new StringBuilder();
-            labelBuilder.append("<table border='0' cellborder='0' cellspacing='0'>");
-            labelBuilder.append("<tr><td bgcolor='")
+            labelBuilder.append("<table border='0' cellborder='0' cellspacing='0'>")
+                    .append("<th border='1'><td cellpadding='5' bgcolor='")
                     .append(headerColor)
-                    .append("'><font color='white'>")
+                    .append("'><font color='white'><b>&nbsp;")
                     .append(key)
-                    .append("</font></td></tr>");
+                    .append("&nbsp;</b></font></td></th>");
             cluster.nodes().stream().map(MutableNode::name).map(Label::toString).sorted()
                     .forEach(nodeName -> {
-                        labelBuilder.append("<tr>");
-                        String prefix = null;
-                        switch (clusterName) {
-                            case "MavenAPI": prefix = "../api/"; break;
-                            case "MavenImplementation": prefix = "../impl/"; break;
-                            case "MavenCompatibility": prefix = "../compat/"; break;
-                            case "MavenResolver": prefix = "https://maven.apache.org/resolver/"; break;
-                        }
+                        labelBuilder.append("<tr><td align='left'");
                         if (prefix != null) {
-                            labelBuilder.append("<td")
-                                    .append(" href=\"")
-                                    .append(prefix)
-                                    .append(nodeName)
-                                    .append("\"")
-                                    .append(" title=\"")
-                                    .append(nodeName)
-                                    .append("\"")
-                                    .append(" target=\"_parent\"")
-                                    .append(">")
-                                    .append(nodeName)
-                                    .append("</td>");
-                        } else {
-                            labelBuilder.append("<td>").append(nodeName).append("</td>");
+                            labelBuilder.append(" href='").append(prefix).append(nodeName)
+                                    .append("' title='").append(nodeName).append("' target='_parent'");
                         }
-                        labelBuilder.append("</tr>");
+                        labelBuilder.append(">").append(nodeName).append("</td></tr>");
                     });
             labelBuilder.append("</table>");
 
@@ -257,6 +247,17 @@ private static MutableGraph generateHighLevelGraph(MutableGraph clusteredGraph,
             }
         }
 
+        // force top group
+        MutableGraph topGroup = mutGraph("top")
+                .setDirected(true)
+                .graphAttrs().add(Rank.inSubgraph(Rank.RankType.SAME))
+                .add(
+                        mutNode("MavenResolver"),
+                        mutNode("MavenAPI"),
+                        mutNode("MavenImplementation")
+                );
+        highLevelGraph.add(topGroup);
+
         return highLevelGraph;
     }