You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "masahi (via GitHub)" <gi...@apache.org> on 2023/03/22 21:01:17 UTC

[GitHub] [tvm] masahi commented on a diff in pull request #14274: [Unity][Transform] SplitCallTIRByPattern and CUTLASS backend

masahi commented on code in PR #14274:
URL: https://github.com/apache/tvm/pull/14274#discussion_r1145404068


##########
python/tvm/contrib/cutlass/gemm_operation.py:
##########
@@ -369,7 +369,8 @@ def instantiate_gemm_template(attrs):
             {
                 "bias_decl": "void* ptr_bias = (void*)(${bias_arg}->data);\n",
                 "ptr_c": "ptr_bias",
-                "c_stride": "${bias_arg}->ndim == 1 ? 0 : " + attrs["ldc"],
+                # "c_stride": "${bias_arg}->ndim == 1 ? 0 : " + attrs["ldc"],

Review Comment:
   This would break one of the cutlass tests, https://github.com/apache/tvm/blob/unity/tests/python/relax/test_codegen_cutlass.py#L367-L369



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org