You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/02/13 02:55:03 UTC
[GitHub] [incubator-echarts] Ovilia opened a new pull request #12144: Fix
11781: save svg image with toolbox
Ovilia opened a new pull request #12144: Fix 11781: save svg image with toolbox
URL: https://github.com/apache/incubator-echarts/pull/12144
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
To support saving SVG images with toolbox. Also works for connected charts.
### Fixed issues
- #11781: Bug: download svg image with toolbox
## Details
### Before: What was the problem?
1. Default suffix of the downloaded file with SVG charts was `.png` if [saveAsImage.type](https://echarts.apache.org/zh/option.html#toolbox.feature.saveAsImage.type) is not set manually, which should be `.svg` because the downloaded file is an SVG file.
2. The downloaded SVG has an error in it and cannot be opened even after changing the file suffix to be `.svg`
3. It didn't work for connected charts.
### After: How is it fixed in this PR?
1. The default suffix is `.svg` if the chart renderer is `'svg'`.
2. No error after the fix.
3. It works for connected charts now and the background is set to be [connectedBackgroundColor](https://echarts.apache.org/zh/option.html#toolbox.feature.saveAsImage.connectedBackgroundColor), which is the same as Canvas behavior.
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
Test case: toolbox-saveImage-background-svg.html
The saved SVG file should look the same as the charts.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia merged pull request #12144: Fix 11781:
save svg image with toolbox
Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #12144: Fix 11781: save svg image with toolbox
URL: https://github.com/apache/incubator-echarts/pull/12144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12144: Fix
11781: save svg image with toolbox
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12144: Fix 11781: save svg image with toolbox
URL: https://github.com/apache/incubator-echarts/pull/12144#issuecomment-586075321
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12144: Fix
11781: save svg image with toolbox
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12144: Fix 11781: save svg image with toolbox
URL: https://github.com/apache/incubator-echarts/pull/12144#issuecomment-585524720
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org