You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/02/20 04:58:37 UTC

[GitHub] [thrift] allengeorge opened a new pull request #2336: THRIFT-5299: Encode sequence numbers as non-zigzag varint

allengeorge opened a new pull request #2336:
URL: https://github.com/apache/thrift/pull/2336


   Client: rs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] allengeorge commented on pull request #2336: THRIFT-5299: Encode sequence numbers as non-zigzag varint

Posted by GitBox <gi...@apache.org>.
allengeorge commented on pull request #2336:
URL: https://github.com/apache/thrift/pull/2336#issuecomment-782904186


   Ah, dammit - super sorry :/ Forgot to "squash and merge".


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] allengeorge commented on pull request #2336: THRIFT-5299: Encode sequence numbers as non-zigzag varint

Posted by GitBox <gi...@apache.org>.
allengeorge commented on pull request #2336:
URL: https://github.com/apache/thrift/pull/2336#issuecomment-782904015


   AFAICT, looking at the cross tests this looks like it works as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] allengeorge merged pull request #2336: THRIFT-5299: Encode sequence numbers as non-zigzag varint

Posted by GitBox <gi...@apache.org>.
allengeorge merged pull request #2336:
URL: https://github.com/apache/thrift/pull/2336


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org