[GitHub] [shardingsphere] sandynz commented on pull request #16695: YamlJdbcConfiguration compatible with url and jdbcUrl

[GitBox <gi...@apache.org>]

sandynz commented on PR #16695:
URL: https://github.com/apache/shardingsphere/pull/16695#issuecomment-1096667997

   Additional, `PostgreSQLDataSourceChecker` is reused by openGauss, `checkTableExisted` try to get tables from current connected database, it might get unexpected tables. Since target tables will be checked at next step, so it's not necessary to  do it here.
   
   When I tested on MogDB, it thrown exception:
   ```
   Caused by: org.opengauss.util.PSQLException: [127.0.0.1:64577/127.0.0.1:15432] ERROR: relation "compat_testing" does not exist on mogdb
     位置：15
   	at org.opengauss.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2820)
   	at org.opengauss.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2550)
   	at org.opengauss.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:329)
   	at org.opengauss.jdbc.PgStatement.executeInternal(PgStatement.java:453)
   	at org.opengauss.jdbc.PgStatement.execute(PgStatement.java:377)
   	at org.opengauss.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:149)
   	at org.opengauss.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:112)
   	at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeQuery(ProxyPreparedStatement.java:52)
   	at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeQuery(HikariProxyPreparedStatement.java)
   	at org.apache.shardingsphere.data.pipeline.postgresql.check.datasource.PostgreSQLDataSourceChecker.checkTableExisted(PostgreSQLDataSourceChecker.java:58)
   	at org.apache.shardingsphere.data.pipeline.postgresql.check.datasource.PostgreSQLDataSourceChecker.checkPrivilege(PostgreSQLDataSourceChecker.java:47)
   	... 15 common frames omitted
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org