[geode] branch develop updated: GEODE-5829: Do not bind to both localhost and the actual address of the host (#2578)

[je...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jensdeppe pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 83a3d17  GEODE-5829: Do not bind to both localhost and the actual address of the host (#2578)
83a3d17 is described below

commit 83a3d179da4d15e2901e920e18b1e3bd54396500
Author: Jens Deppe <jd...@pivotal.io>
AuthorDate: Tue Oct 9 15:37:48 2018 -0700

    GEODE-5829: Do not bind to both localhost and the actual address of the host (#2578)
    
    - There is a subtle, low-level networking issue on Windows. See here
      https://stackoverflow.com/questions/52653506/udp-socket-binding-and-sending-behavior-on-windows-1709
      and here
      https://serverfault.com/questions/934207/socket-binding-and-sending-on-different-addresses
---
 .../cache/wan/wancommand/CreateGatewayReceiverCommandDUnitTest.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/wancommand/CreateGatewayReceiverCommandDUnitTest.java b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/wancommand/CreateGatewayReceiverCommandDUnitTest.java
index 3c8631c..4eeb892 100644
--- a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/wancommand/CreateGatewayReceiverCommandDUnitTest.java
+++ b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/wancommand/CreateGatewayReceiverCommandDUnitTest.java
@@ -357,14 +357,13 @@ public class CreateGatewayReceiverCommandDUnitTest {
   @Test
   public void testCreateGatewayReceiverWithDefaultsAndMultipleBindAddressProperties()
       throws Exception {
-    String extraBindAddress = "localhost";
     String receiverGroup = "receiverGroup";
     Integer locator1Port = locatorSite1.getPort();
     String expectedBindAddress = getBindAddress();
 
     Properties props = new Properties();
     props.setProperty(GROUPS, receiverGroup);
-    props.setProperty(BIND_ADDRESS, extraBindAddress);
+    props.setProperty(BIND_ADDRESS, expectedBindAddress);
     props.setProperty(SERVER_BIND_ADDRESS, expectedBindAddress);
 
     server1 = clusterStartupRule.startServerVM(1, props, locator1Port);