You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/08 05:23:53 UTC

[GitHub] [pulsar] zymap opened a new pull request #10512: [Branch-2.7] Fix deadlock on Monitoring thread blocked by LeaderService.isLeader()

zymap opened a new pull request #10512:
URL: https://github.com/apache/pulsar/pull/10512


   ---
   
   Fixes #10235
   
   According to #10235, when `LeaderService` is changing leadership status
   (like losing leadership, or becoming a leader), the `LeaderService` will
   be locked with `synchronized` block. Which will block other threads if
   calling `LeaderService.isLeader()`. This PR changes `ClusterServiceCoordinator`
   and `WorkerStatsManager` to check if is leader from `MembershipManager`,
   which will not block other threads if `LeaderService` is at `synchronized` block.
   
   Also, this PR will not resolve the root cause of #10235, since there is
   lack of context about blocked reader for the `FunctionAssignmentTailer`.
   
   - [ ] Make sure that the change passes the CI checks.
   
   --- 
   Original PR is https://github.com/apache/pulsar/pull/10502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #10512: [Branch-2.7] Fix deadlock on Monitoring thread blocked by LeaderService.isLeader()

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10512:
URL: https://github.com/apache/pulsar/pull/10512


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org