You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/11 16:10:39 UTC
[GitHub] [dubbo-go] zouyx opened a new pull request #602: Mod: update the comments in protocol directory
zouyx opened a new pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
* update the comments in protocol directory
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602#issuecomment-642784152
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=h1) Report
> Merging [#602](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.65%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 66.80% 67.45% +0.65%
===========================================
Files 185 188 +3
Lines 9749 9852 +103
===========================================
+ Hits 6513 6646 +133
+ Misses 2600 2556 -44
- Partials 636 650 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <ø> (-1.22%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `77.50% <ø> (ø)` | |
| [protocol/dubbo/config.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29uZmlnLmdv) | `13.15% <ø> (ø)` | |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `91.83% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `89.47% <ø> (ø)` | |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <ø> (ø)` | |
| [protocol/grpc/grpc\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2ludm9rZXIuZ28=) | `70.96% <0.00%> (ø)` | |
| [protocol/grpc/grpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX3Byb3RvY29sLmdv) | `95.23% <ø> (ø)` | |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <ø> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=footer). Last update [106040d...ca81e2f](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602#issuecomment-642784152
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=h1) Report
> Merging [#602](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/b9f71f79de88500e0c6866f338ff42d7cfe6ed94&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
- Coverage 67.20% 67.14% -0.07%
===========================================
Files 190 190
Lines 9918 9918
===========================================
- Hits 6665 6659 -6
- Misses 2596 2603 +7
+ Partials 657 656 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <ø> (ø)` | |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <ø> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/config.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29uZmlnLmdv) | `13.15% <ø> (ø)` | |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `91.83% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (ø)` | |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `61.70% <ø> (ø)` | |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <ø> (ø)` | |
| [protocol/grpc/grpc\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2ludm9rZXIuZ28=) | `70.96% <0.00%> (ø)` | |
| [protocol/grpc/grpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX3Byb3RvY29sLmdv) | `95.23% <ø> (ø)` | |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <ø> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=footer). Last update [b9f71f7...57f75ee](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng merged pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
fangyincheng merged pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602#issuecomment-642784152
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=h1) Report
> Merging [#602](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.65%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 66.80% 67.45% +0.65%
===========================================
Files 185 188 +3
Lines 9749 9852 +103
===========================================
+ Hits 6513 6646 +133
+ Misses 2600 2556 -44
- Partials 636 650 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <ø> (-1.22%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `77.50% <ø> (ø)` | |
| [protocol/dubbo/config.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29uZmlnLmdv) | `13.15% <ø> (ø)` | |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `91.83% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `89.47% <ø> (ø)` | |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <ø> (ø)` | |
| [protocol/grpc/grpc\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2ludm9rZXIuZ28=) | `70.96% <0.00%> (ø)` | |
| [protocol/grpc/grpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX3Byb3RvY29sLmdv) | `95.23% <ø> (ø)` | |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <ø> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=footer). Last update [106040d...ef3febf](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602#issuecomment-642784152
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=h1) Report
> Merging [#602](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.61%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 66.80% 67.41% +0.61%
===========================================
Files 185 188 +3
Lines 9749 9852 +103
===========================================
+ Hits 6513 6642 +129
+ Misses 2600 2557 -43
- Partials 636 653 +17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <ø> (ø)` | |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `77.50% <ø> (ø)` | |
| [protocol/dubbo/config.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29uZmlnLmdv) | `13.15% <ø> (ø)` | |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `91.83% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `89.47% <ø> (ø)` | |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <ø> (ø)` | |
| [protocol/grpc/grpc\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2ludm9rZXIuZ28=) | `70.96% <0.00%> (ø)` | |
| [protocol/grpc/grpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX3Byb3RvY29sLmdv) | `95.23% <ø> (ø)` | |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <ø> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=footer). Last update [106040d...b5f8646](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602#issuecomment-642784152
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=h1) Report
> Merging [#602](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.61%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 66.80% 67.41% +0.61%
===========================================
Files 185 188 +3
Lines 9749 9852 +103
===========================================
+ Hits 6513 6642 +129
+ Misses 2600 2557 -43
- Partials 636 653 +17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <ø> (ø)` | |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `77.50% <ø> (ø)` | |
| [protocol/dubbo/config.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29uZmlnLmdv) | `13.15% <ø> (ø)` | |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `91.83% <ø> (ø)` | |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `89.47% <ø> (ø)` | |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <ø> (ø)` | |
| [protocol/grpc/grpc\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2ludm9rZXIuZ28=) | `70.96% <0.00%> (ø)` | |
| [protocol/grpc/grpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX3Byb3RvY29sLmdv) | `95.23% <ø> (ø)` | |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <ø> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo-go/pull/602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=footer). Last update [106040d...ef3febf](https://codecov.io/gh/apache/dubbo-go/pull/602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #602: Mod: update the comments in protocol directory
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #602:
URL: https://github.com/apache/dubbo-go/pull/602#discussion_r439741269
##########
File path: protocol/invocation/rpcinvocation.go
##########
@@ -31,7 +31,7 @@ import (
// ///////////////////////////
// todo: is it necessary to separate fields of consumer(provider) from RPCInvocation
-// RPCInvocation ...
+// RPCInvocation is invocation implement of RPC.
Review comment:
使用 nolint 吧。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org