[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #16357: [fix][client-tool]fix the topic offload policy param will be covered unexpected.

[GitBox <gi...@apache.org>]

gaozhangmin commented on code in PR #16357:
URL: https://github.com/apache/pulsar/pull/16357#discussion_r913733227


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java:
##########
@@ -1729,6 +1743,48 @@ void run() throws PulsarAdminException {
                 }
             }
 
+            int maxBlockSizeInBytes = OffloadPoliciesImpl.DEFAULT_MAX_BLOCK_SIZE_IN_BYTES;
+            if (StringUtils.isNotBlank(maxBlockSizeInBytesStr)) {
+                long maxBlockSize = validateSizeString(maxBlockSizeInBytesStr);
+                if (positiveCheck("MaxBlockSizeInBytes", maxBlockSize)
+                        && maxValueCheck("MaxBlockSizeInBytes", maxBlockSize, Integer.MAX_VALUE)) {

Review Comment:
   The same problem also exists in `CmdTopics`.
   Bytes should use  long instead of int, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org