You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/12/22 02:14:33 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3387: ARTEMIS-3027 Fixing AMQP persister encoding

clebertsuconic commented on a change in pull request #3387:
URL: https://github.com/apache/activemq-artemis/pull/3387#discussion_r547027988



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessagePersisterV2.java
##########
@@ -71,8 +70,6 @@ public void encode(ActiveMQBuffer buffer, Message record) {
          buffer.writeInt(properties.getEncodeSize());
          properties.encode(buffer.byteBuf());
       }
-

Review comment:
       why did you need a new persister? you could just check if you have more bytes on the ByteBuffer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org