You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@chemistry.apache.org by fm...@apache.org on 2010/03/08 12:36:42 UTC
svn commit: r920278 - in /incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime: AbstractPersistentCmisObject.java AceImpl.java AllowableActionsImpl.java util/AbstractPagingList.java

Author: fmui
Date: Mon Mar  8 11:36:41 2010
New Revision: 920278

URL: http://svn.apache.org/viewvc?rev=920278&view=rev
Log:
small client API implementation improvements

Modified:
    incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AbstractPersistentCmisObject.java
    incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AceImpl.java
    incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AllowableActionsImpl.java
    incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/util/AbstractPagingList.java

Modified: incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AbstractPersistentCmisObject.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AbstractPersistentCmisObject.java?rev=920278&r1=920277&r2=920278&view=diff
==============================================================================
--- incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AbstractPersistentCmisObject.java (original)
+++ incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AbstractPersistentCmisObject.java Mon Mar  8 11:36:41 2010
@@ -231,7 +231,7 @@
    * @see org.apache.opencmis.client.api.CmisObject#getBaseTypeId()
    */
   public BaseObjectTypeIds getBaseTypeId() {
-    return BaseObjectTypeIds.fromValue((String)getPropertyValue(PropertyIds.CMIS_BASE_TYPE_ID));
+    return BaseObjectTypeIds.fromValue((String) getPropertyValue(PropertyIds.CMIS_BASE_TYPE_ID));
   }
 
   /*
@@ -385,7 +385,7 @@
 
     if ((value == null) || (value.isEmpty())) {
       typeMatch = true;
-      if (value.isEmpty()) {
+      if (value != null) {
         value = null;
       }
     }

Modified: incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AceImpl.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AceImpl.java?rev=920278&r1=920277&r2=920278&view=diff
==============================================================================
--- incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AceImpl.java (original)
+++ incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AceImpl.java Mon Mar  8 11:36:41 2010
@@ -18,6 +18,7 @@
  */
 package org.apache.opencmis.client.runtime;
 
+import java.io.Serializable;
 import java.util.List;
 
 import org.apache.opencmis.client.api.Ace;
@@ -25,7 +26,9 @@
 /**
  * ACE implementation.
  */
-public class AceImpl implements Ace {
+public class AceImpl implements Ace, Serializable {
+
+  private static final long serialVersionUID = 1L;
 
   private String principalId;
   private List<String> permissions;

Modified: incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AllowableActionsImpl.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AllowableActionsImpl.java?rev=920278&r1=920277&r2=920278&view=diff
==============================================================================
--- incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AllowableActionsImpl.java (original)
+++ incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/AllowableActionsImpl.java Mon Mar  8 11:36:41 2010
@@ -18,6 +18,7 @@
  */
 package org.apache.opencmis.client.runtime;
 
+import java.io.Serializable;
 import java.util.Map;
 
 import org.apache.opencmis.client.api.AllowableActions;
@@ -26,7 +27,9 @@
 /**
  * Allowable actions implementation.
  */
-public class AllowableActionsImpl implements AllowableActions {
+public class AllowableActionsImpl implements AllowableActions, Serializable {
+
+  private static final long serialVersionUID = 1L;
 
   private Map<String, Boolean> actions;
 

Modified: incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/util/AbstractPagingList.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/util/AbstractPagingList.java?rev=920278&r1=920277&r2=920278&view=diff
==============================================================================
--- incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/util/AbstractPagingList.java (original)
+++ incubator/chemistry/trunk/opencmis/opencmis-client/opencmis-client-impl/src/main/java/org/apache/opencmis/client/runtime/util/AbstractPagingList.java Mon Mar  8 11:36:41 2010
@@ -254,7 +254,7 @@
         hasMoreItems = next.getHasMoreItems().booleanValue();
       }
 
-      return (next == null ? null : next.getPage());
+      return next.getPage();
     }
 
     public void remove() {