You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 15:41:18 UTC
[GitHub] [airflow] owlphi opened a new pull request #13136: Fix get-schema
owlphi opened a new pull request #13136:
URL: https://github.com/apache/airflow/pull/13136
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #13136:
URL: https://github.com/apache/airflow/pull/13136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi commented on pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
owlphi commented on pull request #13136:
URL: https://github.com/apache/airflow/pull/13136#issuecomment-747966177
Hi @mik-laj, I will add tests to avoid regression as you pointed. I will link this PR with the test. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] halilduygulu commented on pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
halilduygulu commented on pull request #13136:
URL: https://github.com/apache/airflow/pull/13136#issuecomment-777593667
thanks @XD-DENG I started using that version. works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #13136:
URL: https://github.com/apache/airflow/pull/13136#issuecomment-774494672
Hi @halilduygulu to what I can see, this fix has been included in `apache-airflow-providers-google``2.0.0rc1`, which has been published on PyPi two days ago ([changelog](https://github.com/apache/airflow/blob/master/airflow/providers/google/BACKPORT_PROVIDER_CHANGES_2021.02.05.md)).
If it's in rush, you can install `apache-airflow-providers-google`'s `2.0.0rc1`; otherwise I would suggest to you wait for final 2.0.0 for `apache-airflow-providers-google` (which should be there very soon, you can follow [this thread in maillist](https://lists.apache.org/thread.html/rffdfd355a28e08ec7e3e8749eedd51ba8a248107d72e4b893d04af81%40%3Cdev.airflow.apache.org%3E) ) (NOTE: for google provider, this time is a major release from 1.0.0 to 2.0.0, there may be breaking change)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13136:
URL: https://github.com/apache/airflow/pull/13136#issuecomment-747828641
@owlphi Can you add tests to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13136:
URL: https://github.com/apache/airflow/pull/13136#issuecomment-747665889
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] halilduygulu commented on pull request #13136: Fix Google BigQueryHook method get_schema()
Posted by GitBox <gi...@apache.org>.
halilduygulu commented on pull request #13136:
URL: https://github.com/apache/airflow/pull/13136#issuecomment-774036543
How can I get this code into my pip install apache-airflow-providers-google
we need get_schema working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org