You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@deltaspike.apache.org by Antoine Sabot-Durand <an...@sabot-durand.net> on 2014/11/16 19:18:11 UTC

Bug corrected in AnnotatedTypeImpl when used to create AnnotatedType for an Annotation

Hi all,

While preparing my CDI advanced talk for Devoxx [1] I made an intensive use of DeltaSpike core features, especially the AnnotatedTypeBuilder and discovered a bug.
In my talked I wanted to show how to take a third party framework (Drop Wizard Metrics) and integrate it with CDI. One step of this integration was to declare the @Timed annotation as an interceptor binding using BeforeBeanDiscovery#addInterceptorBinding method.
As @Timed contains two members that I wished to become @NonBinding, I decided to use DeltaSpike AnnotatedTypeBuilder to create the required AnnotatedType for @Timed. I realised that the builded AnnotatedType didn’t contained 2 methods but 6 : the 2 @Timed member + the 4 coming from Annotation.
Yesterday I sent a small patch for this bug in DELTASPIKE-781 including test related to this bug.

Thanks,

Antoine

[1] : http://www.slideshare.net/antoinesd/going-further-with-cdi-41411812

Re: Bug corrected in AnnotatedTypeImpl when used to create AnnotatedType for an Annotation

Posted by Antoine Sabot-Durand <an...@sabot-durand.net>.

Thanks Gerhard,

It’s done. I close the ticket.

Antoine


> Le 17 nov. 2014 à 10:36, Gerhard Petracek <ge...@gmail.com> a écrit :
> 
> hi antoine,
> 
> since you are committer, you are welcome to commit at any time.
> if you would like to discuss something, you can provide a patch or follow a
> discussion-workflow like [1].
> please just ensure that you are using rebase instead of merge (see [2]).
> furthermore, everybody should run mvn clean install (before a push) to
> ensure that our (default-)tests as well as checkstyle are fine.
> 
> regards,
> gerhard
> 
> [1]
> http://deltaspike.apache.org/suggested-git-workflows.html#discussion-workflow-optional
> [2] http://deltaspike.apache.org/suggested-git-workflows.html
> 
> 
> 
> 2014-11-17 10:16 GMT+01:00 Antoine Sabot-Durand <an...@sabot-durand.net>:
> 
>> Hi John,
>> 
>> Yes I know I’m listed here, but as I never had the time to contribute to
>> the code (only done communication and help for the new documentation), I
>> thought more respectful to start with a patch. Now as it’s a small
>> correction, I could probably push it myself ;).
>> 
>> Antoine
>> 
>> 
>>> Le 16 nov. 2014 à 19:24, John D. Ament <jo...@gmail.com> a écrit
>> :
>>> 
>>> Antoine,
>>> 
>>> I believe you're already a committer on the project, as per [1].
>>> 
>>> John
>>> 
>>> [1]: http://people.apache.org/committers-by-project.html#deltaspike
>>> 
>>> On Sun, Nov 16, 2014 at 1:18 PM, Antoine Sabot-Durand <
>>> antoine@sabot-durand.net> wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> While preparing my CDI advanced talk for Devoxx [1] I made an intensive
>>>> use of DeltaSpike core features, especially the AnnotatedTypeBuilder and
>>>> discovered a bug.
>>>> In my talked I wanted to show how to take a third party framework (Drop
>>>> Wizard Metrics) and integrate it with CDI. One step of this integration
>> was
>>>> to declare the @Timed annotation as an interceptor binding using
>>>> BeforeBeanDiscovery#addInterceptorBinding method.
>>>> As @Timed contains two members that I wished to become @NonBinding, I
>>>> decided to use DeltaSpike AnnotatedTypeBuilder to create the required
>>>> AnnotatedType for @Timed. I realised that the builded AnnotatedType
>> didn’t
>>>> contained 2 methods but 6 : the 2 @Timed member + the 4 coming from
>>>> Annotation.
>>>> Yesterday I sent a small patch for this bug in DELTASPIKE-781 including
>>>> test related to this bug.
>>>> 
>>>> Thanks,
>>>> 
>>>> Antoine
>>>> 
>>>> [1] :
>> http://www.slideshare.net/antoinesd/going-further-with-cdi-41411812
>> 
>>

Re: Bug corrected in AnnotatedTypeImpl when used to create AnnotatedType for an Annotation

Posted by Gerhard Petracek <ge...@gmail.com>.

hi antoine,

since you are committer, you are welcome to commit at any time.
if you would like to discuss something, you can provide a patch or follow a
discussion-workflow like [1].
please just ensure that you are using rebase instead of merge (see [2]).
furthermore, everybody should run mvn clean install (before a push) to
ensure that our (default-)tests as well as checkstyle are fine.

regards,
gerhard

[1]
http://deltaspike.apache.org/suggested-git-workflows.html#discussion-workflow-optional
[2] http://deltaspike.apache.org/suggested-git-workflows.html



2014-11-17 10:16 GMT+01:00 Antoine Sabot-Durand <an...@sabot-durand.net>:

> Hi John,
>
> Yes I know I’m listed here, but as I never had the time to contribute to
> the code (only done communication and help for the new documentation), I
> thought more respectful to start with a patch. Now as it’s a small
> correction, I could probably push it myself ;).
>
> Antoine
>
>
> > Le 16 nov. 2014 à 19:24, John D. Ament <jo...@gmail.com> a écrit
> :
> >
> > Antoine,
> >
> > I believe you're already a committer on the project, as per [1].
> >
> > John
> >
> > [1]: http://people.apache.org/committers-by-project.html#deltaspike
> >
> > On Sun, Nov 16, 2014 at 1:18 PM, Antoine Sabot-Durand <
> > antoine@sabot-durand.net> wrote:
> >
> >> Hi all,
> >>
> >> While preparing my CDI advanced talk for Devoxx [1] I made an intensive
> >> use of DeltaSpike core features, especially the AnnotatedTypeBuilder and
> >> discovered a bug.
> >> In my talked I wanted to show how to take a third party framework (Drop
> >> Wizard Metrics) and integrate it with CDI. One step of this integration
> was
> >> to declare the @Timed annotation as an interceptor binding using
> >> BeforeBeanDiscovery#addInterceptorBinding method.
> >> As @Timed contains two members that I wished to become @NonBinding, I
> >> decided to use DeltaSpike AnnotatedTypeBuilder to create the required
> >> AnnotatedType for @Timed. I realised that the builded AnnotatedType
> didn’t
> >> contained 2 methods but 6 : the 2 @Timed member + the 4 coming from
> >> Annotation.
> >> Yesterday I sent a small patch for this bug in DELTASPIKE-781 including
> >> test related to this bug.
> >>
> >> Thanks,
> >>
> >> Antoine
> >>
> >> [1] :
> http://www.slideshare.net/antoinesd/going-further-with-cdi-41411812
>
>

Re: Bug corrected in AnnotatedTypeImpl when used to create AnnotatedType for an Annotation

Posted by Antoine Sabot-Durand <an...@sabot-durand.net>.

Hi John,

Yes I know I’m listed here, but as I never had the time to contribute to the code (only done communication and help for the new documentation), I thought more respectful to start with a patch. Now as it’s a small correction, I could probably push it myself ;).

Antoine


> Le 16 nov. 2014 à 19:24, John D. Ament <jo...@gmail.com> a écrit :
> 
> Antoine,
> 
> I believe you're already a committer on the project, as per [1].
> 
> John
> 
> [1]: http://people.apache.org/committers-by-project.html#deltaspike
> 
> On Sun, Nov 16, 2014 at 1:18 PM, Antoine Sabot-Durand <
> antoine@sabot-durand.net> wrote:
> 
>> Hi all,
>> 
>> While preparing my CDI advanced talk for Devoxx [1] I made an intensive
>> use of DeltaSpike core features, especially the AnnotatedTypeBuilder and
>> discovered a bug.
>> In my talked I wanted to show how to take a third party framework (Drop
>> Wizard Metrics) and integrate it with CDI. One step of this integration was
>> to declare the @Timed annotation as an interceptor binding using
>> BeforeBeanDiscovery#addInterceptorBinding method.
>> As @Timed contains two members that I wished to become @NonBinding, I
>> decided to use DeltaSpike AnnotatedTypeBuilder to create the required
>> AnnotatedType for @Timed. I realised that the builded AnnotatedType didn’t
>> contained 2 methods but 6 : the 2 @Timed member + the 4 coming from
>> Annotation.
>> Yesterday I sent a small patch for this bug in DELTASPIKE-781 including
>> test related to this bug.
>> 
>> Thanks,
>> 
>> Antoine
>> 
>> [1] : http://www.slideshare.net/antoinesd/going-further-with-cdi-41411812

Re: Bug corrected in AnnotatedTypeImpl when used to create AnnotatedType for an Annotation

Posted by "John D. Ament" <jo...@gmail.com>.

Antoine,

I believe you're already a committer on the project, as per [1].

John

[1]: http://people.apache.org/committers-by-project.html#deltaspike

On Sun, Nov 16, 2014 at 1:18 PM, Antoine Sabot-Durand <
antoine@sabot-durand.net> wrote:

> Hi all,
>
> While preparing my CDI advanced talk for Devoxx [1] I made an intensive
> use of DeltaSpike core features, especially the AnnotatedTypeBuilder and
> discovered a bug.
> In my talked I wanted to show how to take a third party framework (Drop
> Wizard Metrics) and integrate it with CDI. One step of this integration was
> to declare the @Timed annotation as an interceptor binding using
> BeforeBeanDiscovery#addInterceptorBinding method.
> As @Timed contains two members that I wished to become @NonBinding, I
> decided to use DeltaSpike AnnotatedTypeBuilder to create the required
> AnnotatedType for @Timed. I realised that the builded AnnotatedType didn’t
> contained 2 methods but 6 : the 2 @Timed member + the 4 coming from
> Annotation.
> Yesterday I sent a small patch for this bug in DELTASPIKE-781 including
> test related to this bug.
>
> Thanks,
>
> Antoine
>
> [1] : http://www.slideshare.net/antoinesd/going-further-with-cdi-41411812