You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/01 20:09:04 UTC
[jira] [Commented] (MAHOUT-1975) Pull Request Template
[ https://issues.apache.org/jira/browse/MAHOUT-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991442#comment-15991442 ]
ASF GitHub Bot commented on MAHOUT-1975:
----------------------------------------
GitHub user rawkintrevo opened a pull request:
https://github.com/apache/mahout/pull/313
MAHOUT-1975 Add PR Template for Github PRs
### Purpose of PR:
This PR adds this slick template to the message box when people open PRs!
### Important ToDos
Please mark each with an "x"
- [x] Opening PR against `develop` NOT `master` (OR `feature-name` if this is part of an ongoing feature development).
- [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX
is the JIRA number.
- [ ] Created unit tests where appropriate **N/A**
- [ ] Added licenses correct on newly added files **N/A** (adding license will mess up the template)
- [x] Assigned JIRA to self (almost forgot- thanks template!)
- [ ] Added documentation in scala docs/java docs, (and website once that
is merged to dev) **N/A**
- [ ] Successfully built and ran all unit tests, verified that all tests
pass locally. **N/A** Won't know this is working for sure until it is added to master.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
Oh by the way, does this change break earlier versions?
No
Is this the beginning of a larger project for which a feature branch should be made?
No- straight to dev
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rawkintrevo/mahout mahout-1975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mahout/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
----
> Pull Request Template
> ---------------------
>
> Key: MAHOUT-1975
> URL: https://issues.apache.org/jira/browse/MAHOUT-1975
> Project: Mahout
> Issue Type: Improvement
> Reporter: Trevor Grant
> Assignee: Trevor Grant
> Priority: Minor
> Fix For: 0.13.0, 0.13.1
>
>
> Create a template for guiding new pull requests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)