[GitHub] [arrow-adbc] krlmlr opened a new pull request, #740: chore: Early exit

["krlmlr (via GitHub)" <gi...@apache.org>]

krlmlr opened a new pull request, #740:
URL: https://github.com/apache/arrow-adbc/pull/740

   to keep happy path on a normal indent level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm merged pull request #740: chore(r/adbcdrivermanager): Early exit

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm merged PR #740:
URL: https://github.com/apache/arrow-adbc/pull/740


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #740: chore(r/adbcdrivermanager): Early exit

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #740:
URL: https://github.com/apache/arrow-adbc/pull/740#discussion_r1222071475


##########
r/adbcdrivermanager/R/helpers.R:
##########
@@ -260,31 +260,31 @@ adbc_statement_join <- function(statement, connection) {
 #' @export
 adbc_stream_join <- function(stream, x) {
   if (utils::packageVersion("nanoarrow") >= "0.1.0.9000") {

Review Comment:
   Doesn't this conditional need to be adjusted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org