You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/02/21 20:32:48 UTC
[GitHub] [commons-vfs] nhojpatrick opened a new pull request #243: JUnitj v5 more progression
nhojpatrick opened a new pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243
Everything with this pr and PR #242 now migrated to JUnit v5, unless it depends upon junit.framework.TestCase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #243: JUnitj v5 more progression
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243#discussion_r820123383
##########
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/RunTest.java
##########
@@ -23,6 +23,7 @@
import junit.framework.TestResult;
public class RunTest {
+
Review comment:
In the future, please don't mix in style changes, it makes the PR larger and it takes longer to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] nhojpatrick commented on pull request #243: JUnitj v5 more progression
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243#issuecomment-1059787035
@garydgregory Have removed failing tests as I couldn't quickly fix, will get in the next batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #243: JUnitj v5 more progression
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #243: JUnitj v5 more progression
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243#issuecomment-1059216815
@nhojpatrick Note that the tests are faiing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #243: JUnitj v5 more progression
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243#discussion_r820123383
##########
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/RunTest.java
##########
@@ -23,6 +23,7 @@
import junit.framework.TestResult;
public class RunTest {
+
Review comment:
In the i
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org