You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Peter Werner <l....@vasas.no-ip.org> on 2006/09/18 06:37:45 UTC

Re: Pre-commit hook to verify Perl syntax + build test

> after checking out the code, you either allow the commit or disallow
> it.

No, not in the post-commit.  You can do it in the pre-commit.


BTW, is there anybody here who made a pre-commit check that tries to
run a build (on trunk if it was changed) and reject the commit if build
breaks?  (I'm just about to write one.)

The code "checkout" (svnlook cat)  part is the similar to perl syntax
checking.

  WP

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Pre-commit hook to verify Perl syntax + build test

Posted by Erik Huelsmann <eh...@gmail.com>.
On 9/18/06, Peter Werner <l....@vasas.no-ip.org> wrote:
> > after checking out the code, you either allow the commit or disallow
> > it.
>
> No, not in the post-commit.  You can do it in the pre-commit.
>
>
> BTW, is there anybody here who made a pre-commit check that tries to
> run a build (on trunk if it was changed) and reject the commit if build
> breaks?  (I'm just about to write one.)

No, generally, commits are accepted and a continuous integration
process tests validity. If the build gets broken, the admin operates a
flocking device on the dev who committed that revision.

Seriously: why be so strict as to validate every commit a prio? You
can always roll back to the last working revision: you're using a VCS
:-)

> The code "checkout" (svnlook cat)  part is the similar to perl syntax
> checking.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Pre-commit hook to verify Perl syntax + build test

Posted by allan <al...@muly.dk>.
Peter Werner wrote:
>> after checking out the code, you either allow the commit or disallow
>> it.
> 
> No, not in the post-commit.  You can do it in the pre-commit.

just to clarify. i was speaking in a pre-commit context.

> 
> BTW, is there anybody here who made a pre-commit check that tries to
> run a build (on trunk if it was changed) and reject the commit if build
> breaks?  (I'm just about to write one.)

we tried at one moment, but decided it wan not practical, so decided on 
a post-commit check instead. when people get a email notification with 
the exact error message they are generally quick to fix it themselves.

you could set up a build server that would build on every relevant 
commit/changeset and spit out some status. i guess mileage will wary

./a

> The code "checkout" (svnlook cat)  part is the similar to perl syntax
> checking.
> 
>   WP
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org