You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2023/02/16 15:34:53 UTC
[GitHub] [solr] risdenk commented on a diff in pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0
risdenk commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1108647898
##########
solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorChain.java:
##########
@@ -16,6 +16,7 @@
*/
package org.apache.solr.update.processor;
+import java.io.IOException;
Review Comment:
I don't think `IOException` is needed in this file.
##########
solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorFactory.java:
##########
@@ -16,6 +16,7 @@
*/
package org.apache.solr.update.processor;
+import java.io.IOException;
Review Comment:
I don't think `IOException` is needed in this file.
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -1940,7 +1940,12 @@ public void doReplay(TransactionLog translog) {
ThreadLocal<UpdateRequestProcessor> procThreadLocal =
ThreadLocal.withInitial(
() -> {
- var proc = processorChain.createProcessor(req, rsp);
+ UpdateRequestProcessor proc;
+ try {
+ proc = processorChain.createProcessor(req, rsp);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
Review Comment:
After removing IOException from UpdateRequest files - this change isn't needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org