[jira] [Work logged] (TS-4974) Bad debug assert in HttpSM::handle_server_setup_error

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4974?focusedWorklogId=30664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30664 ]

ASF GitHub Bot logged work on TS-4974:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/16 19:37
            Start Date: 14/Oct/16 19:37
    Worklog Time Spent: 10m 
      Work Description: GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/1113

    TS-4974: Bad debug assert in HttpSM::handle_server_setup_error

    See jira for description.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-4974

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1113
    
----
commit 9d202b3333713baed5b0ccdbeec8d5ca0da53a4c
Author: Susan Hinrichs <sh...@ieee.org>
Date:   2016-10-14T19:35:28Z

    TS-4974: Bad debug assert in HttpSM::handle_server_setup_error

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 30664)
            Time Spent: 10m
    Remaining Estimate: 0h

> Bad debug assert in HttpSM::handle_server_setup_error
> -----------------------------------------------------
>
>                 Key: TS-4974
>                 URL: https://issues.apache.org/jira/browse/TS-4974
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 7.0.0
>            Reporter: Susan Hinrichs
>            Assignee: Susan Hinrichs
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When running with debug_enable, the non-release assert in HttpSM::handle_server_setup_error sometimes goes off.
> ink_assert(server_entry->read_vio == data);
> In the crash case, the data corresponds to server_entry->write_vio. Reviewing the function, I don't see why it is bad that this function is called with the write vio.  The actual IO operations are performed against server_entry->read_vio and server_entry->write_io instead of the parameter vio directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)