[PR] arch/x86_64: The AP retrieves this_task after storing the CPU private… [nuttx]

["xianglyc (via GitHub)" <gi...@apache.org>]

xianglyc opened a new pull request, #14349:
URL: https://github.com/apache/nuttx/pull/14349

   … data
   
   this_task obtains the CPU ID through the GS register, so the initial value of GS needs to be configured in x86_64_cpu_priv_set
   
   *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   
   *Update this section with information on why change is necessary,
    what it exactly does and how, if new feature shows up, provide
    references (dependencies, similar problems and solutions), etc.*
   The AP retrieves this_task after storing the CPU private
   ## Impact
   
   *Update this section, where applicable, on how change affects users,
    build process, hardware, documentation, security, compatibility, etc.*
   no impact
   ## Testing
   
   *Update this section with details on how did you verify the change,
    what Host was used for build (OS, CPU, compiler, ..), what Target was
    used for verification (arch, board:config, ..), etc. Providing build
    and runtime logs from before and after change is highly appreciated.*
   
   ostest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64: The AP retrieves this_task after storing the CPU private… [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14349:
URL: https://github.com/apache/nuttx/pull/14349#issuecomment-2416782404

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   ## NuttX PR Requirements Review
   
   The provided PR description **does not** adequately meet the NuttX requirements. Here's a breakdown:
   
   **Missing Information:**
   
   * **Summary:**
       *  **Why is this change necessary?**  The description vaguely mentions "this_task" and "GS register", but lacks context. What problem does this solve? Is it a bug fix, performance improvement, or new feature?
       * **What exactly does the change do?**  The description is unclear. It mentions "retrieving this_task" and "configuring GS," but doesn't explain how or why. 
       * **How does the change work?**  Provide a technical explanation of the implementation details. 
   * **Impact:**
       * While stating "no impact," the description doesn't address all potential areas. Consider:
           * **Build:**  Does this change add any new dependencies or build flags?
           * **Hardware:**  Does it target specific architectures or boards?
           * **Compatibility:**  Does it introduce any breaking changes?
   * **Testing:**
       * **Insufficient Detail:**  "ostest" isn't descriptive enough. 
       * **Missing Logs:**  Provide build and runtime logs from *before* and *after* the change to demonstrate the issue and the fix.
       * **Target Information:**  Specify the *exact* target architecture, board, and configuration used for testing. 
   
   **Recommendations:**
   
   1. **Expand the Summary:**  Clearly articulate the problem, solution, and technical approach.
   2. **Thoroughly Address Impact:**  Analyze and document the change's effects on all relevant areas, even if there's "no impact."
   3. **Provide Detailed Testing Information:** Include specific host and target details, clear test cases, and comprehensive logs showcasing the change's effect.
   
   **Remember:** A well-written PR description is crucial for reviewers to understand, assess, and ultimately merge your contribution. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64: The AP retrieves this_task after storing the CPU private… [nuttx]

["GUIDINGLI (via GitHub)" <gi...@apache.org>]

GUIDINGLI merged PR #14349:
URL: https://github.com/apache/nuttx/pull/14349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org