You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by rk...@apache.org on 2015/10/30 17:36:22 UTC
cordova-plugin-camera git commit: CB-7668 android: Adding a sterner
warning for allowedit on Android
Repository: cordova-plugin-camera
Updated Branches:
refs/heads/master 3a8880d0c -> 5ff225d8d
CB-7668 android: Adding a sterner warning for allowedit on Android
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/commit/5ff225d8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/tree/5ff225d8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/diff/5ff225d8
Branch: refs/heads/master
Commit: 5ff225d8dfc6b7868c8e2ce38e58c6bfad860402
Parents: 3a8880d
Author: Richard Knoll <ri...@gmail.com>
Authored: Thu Oct 29 14:35:58 2015 -0700
Committer: Richard Knoll <ri...@gmail.com>
Committed: Thu Oct 29 14:35:58 2015 -0700
----------------------------------------------------------------------
README.md | 3 +--
jsdoc2md/TEMPLATE.md | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/blob/5ff225d8/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index 250057e..6d0861f 100644
--- a/README.md
+++ b/README.md
@@ -447,8 +447,7 @@ Tizen only supports a `destinationType` of
- Any `cameraDirection` value results in a back-facing photo.
-- Android also uses the Crop Activity for allowEdit, even though crop should work and actually pass the cropped image back to Cordova, the only one that works consistently is the one bundled
-with the Google Plus Photos application. Other crops may not work.
+- **`allowEdit` is unpredictable on Android and it should not be used!** The Android implementation of this plugin tries to find and use an application on the user's device to do image cropping. The plugin has no control over what application the user selects to perform the image cropping and it is very possible that the user could choose an incompatible option and cause the plugin to fail. This sometimes works because most devices come with an application that handles cropping in a way that is compatible with this plugin (Google Plus Photos), but it is unwise to rely on that being the case. If image editing is essential to your application, consider seeking a third party library or plugin that provides its own image editing utility for a more robust solution.
- `Camera.PictureSourceType.PHOTOLIBRARY` and `Camera.PictureSourceType.SAVEDPHOTOALBUM` both display the same photo album.
http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/blob/5ff225d8/jsdoc2md/TEMPLATE.md
----------------------------------------------------------------------
diff --git a/jsdoc2md/TEMPLATE.md b/jsdoc2md/TEMPLATE.md
index af0d231..7ea3021 100644
--- a/jsdoc2md/TEMPLATE.md
+++ b/jsdoc2md/TEMPLATE.md
@@ -124,8 +124,7 @@ Tizen only supports a `destinationType` of
- Any `cameraDirection` value results in a back-facing photo.
-- Android also uses the Crop Activity for allowEdit, even though crop should work and actually pass the cropped image back to Cordova, the only one that works consistently is the one bundled
-with the Google Plus Photos application. Other crops may not work.
+- **`allowEdit` is unpredictable on Android and it should not be used!** The Android implementation of this plugin tries to find and use an application on the user's device to do image cropping. The plugin has no control over what application the user selects to perform the image cropping and it is very possible that the user could choose an incompatible option and cause the plugin to fail. This sometimes works because most devices come with an application that handles cropping in a way that is compatible with this plugin (Google Plus Photos), but it is unwise to rely on that being the case. If image editing is essential to your application, consider seeking a third party library or plugin that provides its own image editing utility for a more robust solution.
- `Camera.PictureSourceType.PHOTOLIBRARY` and `Camera.PictureSourceType.SAVEDPHOTOALBUM` both display the same photo album.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org