You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2014/03/04 23:53:00 UTC
Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-610
https://issues.apache.org/jira/browse/MESOS-610
Repository: mesos-git
Description
-------
MESOS-610: Split slave specific tests out of master_tests.
Not that most of the tests in master_test.cpp are very master-specific to begin with.
Nor are any of them terribly slave-specific.
Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
The submitted patch suggests a more or less plausible split,
but other divisions are easily thinkable.
I'd also be happy with keeping them all in one file and renaming that file,
maybe to "mesos_tests.cpp"?
Diffs
-----
Diff: https://reviews.apache.org/r/18752/diff/
Testing
-------
Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On March 17, 2014, 12:58 p.m., Vinod Kone wrote:
> > How about splitting the master tests as follows:
> >
> > Everything in master_tests except:
> >
> > ShutdownUnregisteredExecutor
> > RemoveUnregisteredTerminatedExecutor
> >
No problem with that. Will implement!
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review37444
-----------------------------------------------------------
On March 10, 2014, 1:37 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18752/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 1:37 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-610
> https://issues.apache.org/jira/browse/MESOS-610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MESOS-610: Split slave specific tests out of master_tests.
>
> Not that most of the tests in master_test.cpp are very master-specific to begin with.
> Nor are any of them terribly slave-specific.
> Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
> The submitted patch suggests a more or less plausible split,
> but other divisions are easily thinkable.
>
> I'd also be happy with keeping them all in one file and renaming that file,
> maybe to "mesos_tests.cpp"?
>
>
> Diffs
> -----
>
> src/Makefile.am 61d832b
> src/tests/master_tests.cpp 42c5a77
> src/tests/slave_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18752/diff/
>
>
> Testing
> -------
>
> Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review37444
-----------------------------------------------------------
How about splitting the master tests as follows:
Everything in master_tests except:
ShutdownUnregisteredExecutor
RemoveUnregisteredTerminatedExecutor
- Vinod Kone
On March 10, 2014, 8:37 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18752/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 8:37 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-610
> https://issues.apache.org/jira/browse/MESOS-610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MESOS-610: Split slave specific tests out of master_tests.
>
> Not that most of the tests in master_test.cpp are very master-specific to begin with.
> Nor are any of them terribly slave-specific.
> Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
> The submitted patch suggests a more or less plausible split,
> but other divisions are easily thinkable.
>
> I'd also be happy with keeping them all in one file and renaming that file,
> maybe to "mesos_tests.cpp"?
>
>
> Diffs
> -----
>
> src/Makefile.am 61d832b
> src/tests/master_tests.cpp 42c5a77
> src/tests/slave_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18752/diff/
>
>
> Testing
> -------
>
> Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review38450
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18752]
All tests passed.
- Mesos ReviewBot
On March 25, 2014, 3:37 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18752/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 3:37 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-610
> https://issues.apache.org/jira/browse/MESOS-610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MESOS-610: Split slave specific tests out of master_tests.
>
> Not that most of the tests in master_test.cpp are very master-specific to begin with.
> Nor are any of them terribly slave-specific.
> Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
> The submitted patch suggests a more or less plausible split,
> but other divisions are easily thinkable.
>
> I'd also be happy with keeping them all in one file and renaming that file,
> maybe to "mesos_tests.cpp"?
>
>
> Diffs
> -----
>
> src/Makefile.am 0775a0d
> src/tests/master_tests.cpp 4395883
> src/tests/slave_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18752/diff/
>
>
> Testing
> -------
>
> Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review38454
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 25, 2014, 3:37 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18752/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 3:37 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-610
> https://issues.apache.org/jira/browse/MESOS-610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MESOS-610: Split slave specific tests out of master_tests.
>
> Not that most of the tests in master_test.cpp are very master-specific to begin with.
> Nor are any of them terribly slave-specific.
> Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
> The submitted patch suggests a more or less plausible split,
> but other divisions are easily thinkable.
>
> I'd also be happy with keeping them all in one file and renaming that file,
> maybe to "mesos_tests.cpp"?
>
>
> Diffs
> -----
>
> src/Makefile.am 0775a0d
> src/tests/master_tests.cpp 4395883
> src/tests/slave_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18752/diff/
>
>
> Testing
> -------
>
> Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/
-----------------------------------------------------------
(Updated March 25, 2014, 8:37 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Split tests as suggested by Vinod.
Bugs: MESOS-610
https://issues.apache.org/jira/browse/MESOS-610
Repository: mesos-git
Description
-------
MESOS-610: Split slave specific tests out of master_tests.
Not that most of the tests in master_test.cpp are very master-specific to begin with.
Nor are any of them terribly slave-specific.
Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
The submitted patch suggests a more or less plausible split,
but other divisions are easily thinkable.
I'd also be happy with keeping them all in one file and renaming that file,
maybe to "mesos_tests.cpp"?
Diffs (updated)
-----
src/Makefile.am 0775a0d
src/tests/master_tests.cpp 4395883
src/tests/slave_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/18752/diff/
Testing
-------
Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/
-----------------------------------------------------------
(Updated March 10, 2014, 8:37 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
assigning to myself for review. -- Vinod
Bugs: MESOS-610
https://issues.apache.org/jira/browse/MESOS-610
Repository: mesos-git
Description
-------
MESOS-610: Split slave specific tests out of master_tests.
Not that most of the tests in master_test.cpp are very master-specific to begin with.
Nor are any of them terribly slave-specific.
Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
The submitted patch suggests a more or less plausible split,
but other divisions are easily thinkable.
I'd also be happy with keeping them all in one file and renaming that file,
maybe to "mesos_tests.cpp"?
Diffs
-----
src/Makefile.am 61d832b
src/tests/master_tests.cpp 42c5a77
src/tests/slave_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/18752/diff/
Testing
-------
Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review36514
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18752]
All tests passed.
- Mesos ReviewBot
On March 4, 2014, 11:13 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18752/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 11:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-610
> https://issues.apache.org/jira/browse/MESOS-610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MESOS-610: Split slave specific tests out of master_tests.
>
> Not that most of the tests in master_test.cpp are very master-specific to begin with.
> Nor are any of them terribly slave-specific.
> Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
> The submitted patch suggests a more or less plausible split,
> but other divisions are easily thinkable.
>
> I'd also be happy with keeping them all in one file and renaming that file,
> maybe to "mesos_tests.cpp"?
>
>
> Diffs
> -----
>
> src/Makefile.am 61d832b
> src/tests/master_tests.cpp 42c5a77
> src/tests/slave_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18752/diff/
>
>
> Testing
> -------
>
> Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/
-----------------------------------------------------------
(Updated March 4, 2014, 3:13 p.m.)
Review request for mesos.
Changes
-------
diff file
Bugs: MESOS-610
https://issues.apache.org/jira/browse/MESOS-610
Repository: mesos-git
Description
-------
MESOS-610: Split slave specific tests out of master_tests.
Not that most of the tests in master_test.cpp are very master-specific to begin with.
Nor are any of them terribly slave-specific.
Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
The submitted patch suggests a more or less plausible split,
but other divisions are easily thinkable.
I'd also be happy with keeping them all in one file and renaming that file,
maybe to "mesos_tests.cpp"?
Diffs (updated)
-----
src/Makefile.am 61d832b
src/tests/master_tests.cpp 42c5a77
src/tests/slave_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/18752/diff/
Testing
-------
Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18752: MESOS-610: Split slave specific tests out of
master_tests
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review36185
-----------------------------------------------------------
Looks like you're missing the diff Bernd!
- Benjamin Hindman
On March 4, 2014, 10:52 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18752/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 10:52 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-610
> https://issues.apache.org/jira/browse/MESOS-610
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MESOS-610: Split slave specific tests out of master_tests.
>
> Not that most of the tests in master_test.cpp are very master-specific to begin with.
> Nor are any of them terribly slave-specific.
> Typically, any such tests concern the whole Mesos conglomerate including the scheduler driver.
> The submitted patch suggests a more or less plausible split,
> but other divisions are easily thinkable.
>
> I'd also be happy with keeping them all in one file and renaming that file,
> maybe to "mesos_tests.cpp"?
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/18752/diff/
>
>
> Testing
> -------
>
> Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and Ubuntu 13.10 / gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>