You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "wcy-fdu (via GitHub)" <gi...@apache.org> on 2023/04/09 06:51:35 UTC

[GitHub] [incubator-opendal] wcy-fdu opened a new pull request, #1889: feat(metrics): add some metrics via prometheus register [Ignore me]

wcy-fdu opened a new pull request, #1889:
URL: https://github.com/apache/incubator-opendal/pull/1889

   This PR aims to introduce prometheus register to monitor performance, and is **working in progress, please ignore this PR for a while.**
   
   Todo(possible)
   - [ ] define metrics for accessor
   - [ ] add `AccessorBasicMetrics` in Accessor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on pull request #1889: feat(metrics): add prometheus layer [Ignore me]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1889:
URL: https://github.com/apache/incubator-opendal/pull/1889#issuecomment-1501108763

   Hello @wcy-fdu, thank you for submitting this PR!
   
   I will temporarily close the PR to give you more space to improve it. By closing on-going (instead of on-reviewing) PR allow both of us foucing our own work. Please note that closing the PR does not mean rejection; feel free to reopen it when you are ready for further review or feedback.
   
   Thank you again and have a great day!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on pull request #1889: feat(metrics): add some metrics via prometheus register [Ignore me]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1889:
URL: https://github.com/apache/incubator-opendal/pull/1889#issuecomment-1501073470

   > I saw that MetricsHandler already contains many metrics, should I just convert these metrics to use prometheus register in the new Prometheus Layer?
   
   Just assume that there is no MetricsLayer existing. All layers should work independently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo closed pull request #1889: feat(metrics): add prometheus layer [Ignore me]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed pull request #1889: feat(metrics): add prometheus layer [Ignore me]
URL: https://github.com/apache/incubator-opendal/pull/1889


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on pull request #1889: feat(metrics): add some metrics via prometheus register [Ignore me]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1889:
URL: https://github.com/apache/incubator-opendal/pull/1889#issuecomment-1501065023

   This feature should be implemented in `layer` instead of in `raw`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] wcy-fdu commented on pull request #1889: feat(metrics): add some metrics via prometheus register [Ignore me]

Posted by "wcy-fdu (via GitHub)" <gi...@apache.org>.
wcy-fdu commented on PR #1889:
URL: https://github.com/apache/incubator-opendal/pull/1889#issuecomment-1501072690

   > This feature should be implemented in `layer` instead of in `raw`. Please take MetricsLayer as a reference.
   
   I saw that `MetricsHandler` already contains many metrics, should I just convert these metrics to use prometheus register in the new `Prometheus Layer`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org