You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Karich (JIRA)" <ji...@apache.org> on 2010/09/16 15:58:33 UTC

[jira] Created: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

HybridUrlCodingStrategy probably uses wrong url encoding
--------------------------------------------------------

                 Key: WICKET-3052
                 URL: https://issues.apache.org/jira/browse/WICKET-3052
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.9
            Reporter: Peter Karich


try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:

Problem accessing /jetwick/twittersearch/q/. Reason:
    NOT_FOUND

The problematic url is:
http://localhost:8080/jetwick/twittersearch/q/#wicket.5

the correct url should be:
http://localhost:8080/jetwick/twittersearch/q/%23wicket.5

if you type that in you'll get the correct response. 

Another problem is when the keyword ends with a dot '.' like described here:

http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Karich reopened WICKET-3052:
----------------------------------


Hmmh now I am hitting a similar issue on tomcat.

if you take the quickstart project and type e.g. \test where the backslash is important then you will get an empty page. (for jetty all is fine)

The resulting url is:

http://localhost:8080/jetwick-1.0-SNAPSHOT/twittersearch/q/%5Ctest

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912269#action_12912269 ] 

Martin Grigorov commented on WICKET-3052:
-----------------------------------------

I tracked down the problem to org.mortbay.jetty.Response.sendRedirect(String url).
We always pass encoded url (i.e. with '%23' instead of '#'), but Jetty's #sendRedirect() calls :
  HttpURI uri = new HttpURI(location);
  String path=uri.getDecodedPath(); 
and then sets the decoded URL as value in the header.

I don't see a reason why Jetty does this but I cannot find in the web any complaints about this behavior of Jetty too.
I'll ask in their forums.

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916405#action_12916405 ] 

Martin Grigorov commented on WICKET-3052:
-----------------------------------------

Try again. I re-attached it to JETTY-1277.
It was twice gzipped, once tar-ed ... Don't ask me how I did that.

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915267#action_12915267 ] 

Martin Grigorov commented on WICKET-3052:
-----------------------------------------

I guess it is in Tomcat now.
Use the demo application from http://jira.codehaus.org/browse/JETTY-1277 and modify it to use backslash and see what headers Tomcat sets.

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-3052:
---------------------------------------

    Assignee: Martin Grigorov

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Karich closed WICKET-3052.
--------------------------------

    Resolution: Not A Problem

problem of jetty not of wicket

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912453#action_12912453 ] 

Peter Karich commented on WICKET-3052:
--------------------------------------

ok, I can confirm that this works with tomcat!

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915017#action_12915017 ] 

Peter Karich edited comment on WICKET-3052 at 9/26/10 2:46 PM:
---------------------------------------------------------------

Hmmh now I am hitting a similar issue on tomcat.

if you take the quickstart project and type e.g. \test where the backslash is important then you will get an empty page. (for jetty all is fine)

The resulting url is:

http://localhost:8080/jetwick-1.0-SNAPSHOT/twittersearch/q/%5Ctest

Where is my/the mistake?

      was (Author: peathal):
    Hmmh now I am hitting a similar issue on tomcat.

if you take the quickstart project and type e.g. \test where the backslash is important then you will get an empty page. (for jetty all is fine)

The resulting url is:

http://localhost:8080/jetwick-1.0-SNAPSHOT/twittersearch/q/%5Ctest
  
> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Karich updated WICKET-3052:
---------------------------------

    Attachment: wicket-bug-qs.zip

execute:

mvn jetty:run

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912372#action_12912372 ] 

Peter Karich commented on WICKET-3052:
--------------------------------------

> I tracked down the problem to org.mortbay.jetty.Response.sendRedirect(String url). 

ah, ok. this means it should work in tomcat ... I'll try that! Thanks!

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912275#action_12912275 ] 

Martin Grigorov commented on WICKET-3052:
-----------------------------------------

http://jira.codehaus.org/browse/JETTY-1277

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916298#action_12916298 ] 

Peter Karich commented on WICKET-3052:
--------------------------------------

'tar xzf redirect-problem.tgz' says it cannot open the archive. can you confirm that?

(Someone hinders me solving those issues ;-))

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3052) HybridUrlCodingStrategy probably uses wrong url encoding

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3052.
-------------------------------------

       Resolution: Invalid
    Fix Version/s: 1.5-M3
                   1.4.13

Closing again as "Invalid".
There is no problem on Wicket side.

> HybridUrlCodingStrategy probably uses wrong url encoding
> --------------------------------------------------------
>
>                 Key: WICKET-3052
>                 URL: https://issues.apache.org/jira/browse/WICKET-3052
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Peter Karich
>            Assignee: Martin Grigorov
>             Fix For: 1.4.13, 1.5-M3
>
>         Attachments: wicket-bug-qs.zip
>
>
> try the appended quickstart (created from legup -> wicket 1.4.9): if you query e.g. for '#wicket' you will get:
> Problem accessing /jetwick/twittersearch/q/. Reason:
>     NOT_FOUND
> The problematic url is:
> http://localhost:8080/jetwick/twittersearch/q/#wicket.5
> the correct url should be:
> http://localhost:8080/jetwick/twittersearch/q/%23wicket.5
> if you type that in you'll get the correct response. 
> Another problem is when the keyword ends with a dot '.' like described here:
> http://lazydev.ildella.net/wicket-hybridurlcodingstrategy-and-url-with-d

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.