[GitHub] [solr] khitrin opened a new pull request #280: SOLR-15611: Fix ignored phrase slop after nested query parsing

[GitBox <gi...@apache.org>]

khitrin opened a new pull request #280:
URL: https://github.com/apache/solr/pull/280


   https://issues.apache.org/jira/browse/SOLR-15611
   
   # Description
   Solr query parser is dropping phrase slops after any nested queries parsed in same query because `subQParser` not cleared after magic field processing.
   
   # Solution
   Replace `subQParser` field by `lastMagicField` and check current field name in `getFieldQuery(String field, String queryText, int slop)`.
   
   # Tests
   `_query_:"{!term f=text}foo" "foo bar"~1` and ` `foo "foo bar"~1` should be parsed to same queries, a new test added to TestSolrQueryParser.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org