[GitHub] [iceberg-docs] djamegoldston commented on pull request #91: Replace themes with a single "iceberg-theme" that's shared by landing-page and docs site

[GitBox <gi...@apache.org>]

djamegoldston commented on PR #91:
URL: https://github.com/apache/iceberg-docs/pull/91#issuecomment-1164823509

   @samredai **a few things I noticed:**
   
   - `min-width: 1024px` on the `.markdown-body` class is causing horizontal scrolling on smaller sizes. The anchor links are off-screen.
   - The `20px` font size for `body` looks nice on the home page but makes the nav links in the doc section look giant. ~ `16px` default for the body might be a better default for the rest of the site elements, then size up the homepage body size.
   - Not sure the large Iceberg logo is necessary on the docs page. Maybe just a text `<h1>`. See the simple headlines on [MarkDoc](https://markdoc.io/docs/getting-started) or [Stripe Docs](https://stripe.com/docs) 
   - The equidistant spacing in the nav bar could use some grouping. Maybe something like:
   
   | Group 1 | Group 2 | Group 3 |
   | :--- | :--- | :--- |
   | Logo | Nav Links | Social Links |
   | Search | -- | -- |
   | Versions | -- | -- |
   
   *With larger spacing in between the groups.   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org