You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2012/11/03 02:58:12 UTC

[jira] [Created] (HDFS-4146) Further work on changing INodeFile.blocks to private in Snapshot branch

Tsz Wo (Nicholas), SZE created HDFS-4146:
--------------------------------------------

             Summary: Further work on changing INodeFile.blocks to private in Snapshot branch
                 Key: HDFS-4146
                 URL: https://issues.apache.org/jira/browse/HDFS-4146
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: name-node
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE
            Priority: Minor


There was a conflict in INodeFile when merging HDFS-4143 so that I keep INodeFile.blocks as protected.  Otherwise, some code cannot be compiled.  It needs some more works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4146) Further work on changing INodeFile.blocks to private in Snapshot branch

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490304#comment-13490304 ] 

Suresh Srinivas commented on HDFS-4146:
---------------------------------------

+1 for the change.
                
> Further work on changing INodeFile.blocks to private in Snapshot branch
> -----------------------------------------------------------------------
>
>                 Key: HDFS-4146
>                 URL: https://issues.apache.org/jira/browse/HDFS-4146
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4146_20121104.patch
>
>
> There was a conflict in INodeFile when merging HDFS-4143 so that I keep INodeFile.blocks as protected.  Otherwise, some code cannot be compiled.  It needs some more works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HDFS-4146) Further work on changing INodeFile.blocks to private in Snapshot branch

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE resolved HDFS-4146.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: Snapshot (HDFS-2802)
     Hadoop Flags: Reviewed

Suresh, thanks for the review.

I have committed this.
                
> Further work on changing INodeFile.blocks to private in Snapshot branch
> -----------------------------------------------------------------------
>
>                 Key: HDFS-4146
>                 URL: https://issues.apache.org/jira/browse/HDFS-4146
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: Snapshot (HDFS-2802)
>
>         Attachments: h4146_20121104.patch
>
>
> There was a conflict in INodeFile when merging HDFS-4143 so that I keep INodeFile.blocks as protected.  Otherwise, some code cannot be compiled.  It needs some more works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4146) Further work on changing INodeFile.blocks to private in Snapshot branch

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-4146:
-----------------------------------------

    Attachment: h4146_20121104.patch

h4146_20121104.patch: use getter and setter in INodeFileWithLink to access blocks.  Also initialize root directory as snapshottable since it cannot be replaced.
                
> Further work on changing INodeFile.blocks to private in Snapshot branch
> -----------------------------------------------------------------------
>
>                 Key: HDFS-4146
>                 URL: https://issues.apache.org/jira/browse/HDFS-4146
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4146_20121104.patch
>
>
> There was a conflict in INodeFile when merging HDFS-4143 so that I keep INodeFile.blocks as protected.  Otherwise, some code cannot be compiled.  It needs some more works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira