[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests

["Roland Weber (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551205 ] 

Roland Weber commented on HTTPCLIENT-711:
-----------------------------------------

I suggest the following changes to address this problem:

1. remove HttpClient.execute(RouteRequest...) methods
    (optionally replace with HttpClient.execute(HttpRequest,HttpHost target,...) methods
2. change ClientRequestDirector to expect HttpRequest+HttpHost instead of RoutedRequest
3. change DefaultClientRequestDirector to expect a route planner in the constructor
4. move Abstract/DefaultHttpClient.determineRoute to the ClientRequestDirector
5. move RoutedRequest from the API to an impl package, or drop it altogether
    (it seems to have outlived it's usefulness in the API)

After 4, the request director can take care of all route planning for the original and followup requests.

The purpose of RoutedRequest was to allow application-defined routes. This can now be achieved by implementing a custom route planner and passing an application-defined route as request parameter or in the context. We can also consider to add this functionality to the default route planner.

cheers,
  Roland


> bad route computed for redirected requests
> ------------------------------------------
>
>                 Key: HTTPCLIENT-711
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 2
>            Reporter: Oleg Kalnichevski
>            Priority: Critical
>             Fix For: 4.0 Alpha 3
>
>
> BasicRouteDirector appears to miscalculate complex routes. Example to follow. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org