You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/12 09:09:41 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6729: server: fix network upgrade for IPv6
shwstppr opened a new pull request, #6729:
URL: https://github.com/apache/cloudstack/pull/6729
### Description
Fixes network update for IPv6 offering upgrade
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [x] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
Before fix:
```
# cat /marvin//MarvinLogs/test_network_ipv6_W9ENW4/results.txt
Test to verify IPv6 network ... === TestName: test_01_verify_ipv6_network | Status : SUCCESS ===
ok
Test to verify redundant IPv6 network ... === TestName: test_02_verify_ipv6_network_redundant | Status : SUCCESS ===
ok
Test to verify IPv4 network upgraded to IPv6 network ... === TestName: test_03_verify_upgraded_ipv6_network | Status : EXCEPTION ===
ERROR
Test to verify redundant IPv4 network upgraded to redundant IPv6 network ... === TestName: test_04_verify_upgraded_ipv6_network_redundant | Status : EXCEPTION ===
ERROR
# cat /marvin//MarvinLogs/test_network_ipv6_W9ENW4/failed_plus_exceptions.txt
2022-09-12 09:02:13,776 - CRITICAL - EXCEPTION: test_03_verify_upgraded_ipv6_network: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 60, in testPartExecutor\n yield\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 622, in run\n testMethod()\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/lib/decoratorGenerators.py", line 30, in test_wrapper\n return test(self, *args, **kwargs)\n', ' File "/marvin/tests/component/test_network_ipv6.py", line 888, in test_03_verify_upgraded_ipv6_network\n self.updateNetworkWithOffering()\n', ' File "/marvin/tests/component/test_network_ipv6.py", line 548, in updateNetworkWithOffering\n self.network.update(self.userapiclient, networkofferingid=self.network_offering_update.id)\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/lib/base.py", line 3275, in update\n return (apiclient.updateNetwork(cmd))\n', ' File "/usr/local/lib/python3.6/site-packages/marvin
/cloudstackAPI/cloudstackAPIClient.py", line 2187, in updateNetwork\n response = self.connection.marvinRequest(command, response_type=response, method=method)\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 381, in marvinRequest\n raise e\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 376, in marvinRequest\n raise self.__lastError\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 105, in __poll\n % async_response)\n', 'Exception: Job failed: {accountid : \'2668148f-79d0-465b-924f-6c8d136315cb\', userid : \'48c0288b-bfc8-4b0f-8ea9-471f598ec4fd\', cmd : \'org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd\', jobstatus : 2, jobprocstatus : 0, jobresultcode : 530, jobresulttype : \'object\', jobresult : {errorcode : 530, errortext : "Failed to upgrade network offering to \'Test Network offering-NF816G\' as unable to allocate IPv6 network"}
, jobinstancetype : \'Network\', created : \'2022-09-12T09:01:14+0000\', completed : \'2022-09-12T09:01:14+0000\', jobid : \'915100ce-d7f9-4455-9725-f52ac6dfd3f3\'}\n']
2022-09-12 09:05:45,283 - CRITICAL - EXCEPTION: test_04_verify_upgraded_ipv6_network_redundant: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 60, in testPartExecutor\n yield\n', ' File "/usr/lib64/python3.6/unittest/case.py", line 622, in run\n testMethod()\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/lib/decoratorGenerators.py", line 30, in test_wrapper\n return test(self, *args, **kwargs)\n', ' File "/marvin/tests/component/test_network_ipv6.py", line 928, in test_04_verify_upgraded_ipv6_network_redundant\n self.updateNetworkWithOffering()\n', ' File "/marvin/tests/component/test_network_ipv6.py", line 548, in updateNetworkWithOffering\n self.network.update(self.userapiclient, networkofferingid=self.network_offering_update.id)\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/lib/base.py", line 3275, in update\n return (apiclient.updateNetwork(cmd))\n', ' File "/usr/local/lib/python3.6/
site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2187, in updateNetwork\n response = self.connection.marvinRequest(command, response_type=response, method=method)\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 381, in marvinRequest\n raise e\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 376, in marvinRequest\n raise self.__lastError\n', ' File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 105, in __poll\n % async_response)\n', 'Exception: Job failed: {accountid : \'2668148f-79d0-465b-924f-6c8d136315cb\', userid : \'48c0288b-bfc8-4b0f-8ea9-471f598ec4fd\', cmd : \'org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd\', jobstatus : 2, jobprocstatus : 0, jobresultcode : 530, jobresulttype : \'object\', jobresult : {errorcode : 530, errortext : "Failed to upgrade network offering to \'Network off-RVR services-0HRGO3\' as unable to
allocate IPv6 network"}, jobinstancetype : \'Network\', created : \'2022-09-12T09:04:38+0000\', completed : \'2022-09-12T09:04:38+0000\', jobid : \'3a37d6d5-b841-493d-97dd-105316ea7787\'}\n']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243563082
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6729?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6729](https://codecov.io/gh/apache/cloudstack/pull/6729?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4cfdbc) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/d3bfdacffd1223dbc721f6f006cac26dbe9f98e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3bfdac) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #6729 +/- ##
=========================================
Coverage 5.88% 5.88%
- Complexity 3927 3928 +1
=========================================
Files 2451 2451
Lines 242338 242338
Branches 37923 37923
=========================================
+ Hits 14261 14263 +2
+ Misses 226502 226498 -4
- Partials 1575 1577 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/main/java/com/cloud/network/Ipv6ServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6729/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvSXB2NlNlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/6729/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `62.30% <0.00%> (ø)` | |
| [...apache/cloudstack/alert/snmp/SnmpTrapAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6729/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zbm1wLWFsZXJ0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hbGVydC9zbm1wL1NubXBUcmFwQXBwZW5kZXIuamF2YQ==) | `61.05% <0.00%> (+2.10%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1245835476
<b>Trillian test result (tid-4877)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41926 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6729-t4877-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 551.80 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1244980659
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243492965
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243443456
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243496077
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1245087546
Manually tested failed smoke tests. Failures were intermittent, env related.
[6729.log](https://github.com/apache/cloudstack/files/9555098/6729.log)
Merging this and will keep an eye on health check PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1244980978
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243443116
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243505511
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6729)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6729&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6729&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6729&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6729&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6729&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6729&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6729&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6729&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1243496376
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6729: server: fix network upgrade for IPv6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6729:
URL: https://github.com/apache/cloudstack/pull/6729#issuecomment-1244469885
<b>Trillian test result (tid-4871)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38742 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6729-t4871-kvm-centos7.zip
Smoke tests completed. 96 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_snapshots_with_removed_data_store | `Error` | 9.65 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.65 | test_snapshots.py
test_01_add_primary_storage_disabled_host | `Error` | 0.57 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.20 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.99 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 64.02 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 41.14 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 48.59 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 137.57 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 156.62 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 272.33 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 141.19 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 42.70 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.81 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org