You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/08 10:29:35 UTC

[GitHub] [flink] tisonkun commented on a diff in pull request #21249: [FLINK-26027][Connector/Pulsar] Expose Pulsar metrics

tisonkun commented on code in PR #21249:
URL: https://github.com/apache/flink/pull/21249#discussion_r1016435789


##########
flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSinkE2ECase.java:
##########
@@ -34,7 +34,7 @@
 /** Pulsar sink E2E test based on connector testing framework. */
 @SuppressWarnings("unused")
 @Tag("org.apache.flink.testutils.junit.FailsOnJava11")
-public class PulsarSinkE2ECase extends PulsarSinkTestSuiteBase {
+public class PulsarSinkE2ECase extends SinkTestSuiteBase<String> {

Review Comment:
   Out of topic: IDEA hints me that this test class name doesn't match regex '[A-Z][A-Za-z\d]*Test(s|Case)?|Test[A-Z][A-Za-z\d]*|IT(.*)|(.*)IT(Case)?' . Do we run this test case properly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org