You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "okreda1 (via GitHub)" <gi...@apache.org> on 2024/09/16 15:11:52 UTC
[PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
okreda1 opened a new pull request, #11536:
URL: https://github.com/apache/ignite/pull/11536
- changed default settings for gc log (-Xloggc ->-Xlog:gc)
- added new logs for safepoints
- added new variable to disable safepoints log
- removed UnlockCommercialFeatures because it was used only for jfr, but no longer needed for openjdk11
- removed check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt, because there is no longer an option in settings
- changed option in check_colon_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt to -Xlog:gc
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1768136968
##########
modules/ducktests/tests/ignitetest/services/utils/jvm_utils.py:
##########
@@ -31,14 +31,14 @@
def create_jvm_settings(heap_size=DEFAULT_HEAP, gc_settings=JVM_PARAMS_GC_G1, generic_params=JVM_PARAMS_GENERIC,
- gc_dump_path=None, oom_path=None, vm_error_path=None):
+ gc_dump_path=None, oom_path=None, vm_error_path=None,):
Review Comment:
By mistake, removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771024814
##########
modules/ducktests/README.md:
##########
@@ -77,24 +77,91 @@ You may set versions (products) using `@ignite_versions` decorator at code
```
or passing versions set via globals during the execution
```
---globals-json, eg: {"ignite_versions":["2.8.1", "dev"]}
+--global-json, eg: {"ignite_versions":["2.8.1", "dev"]}
```
You may also specify product prefix by `project` param at globals, for example:
```
---globals-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
+--global-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
```
will execute tests on `ignite-2.8.1, fork-2.8.1, fork-dev`
## Run tests from the external source/repository
TBD
# Special runs
+## Run with FlightRecorder (JFR)
+To run ignite with flight recorder you should enable `jfr_enabled` through globals, for example:
+```
+--global-json, eg: {"jfr_enabled":true}
+```
+## Run with safepoints logging
+Safepoint logging is disabled by default, to enable it, you need to pass `true` for `safepoint_log_enabled` for example:
+```
+--global-json, eg: {"safepoint_log_enabled":true}
+```
## Run with enabled security
### Run with SSL enabled
-TBD
+To enable ssl it is only required to pass `enabled` for `ssl` in globals:
+```
+--global-json, eg: {"ssl":{"enabled":true}}
+```
+
+You can configure ignite ssl connection by passing configs from this structure to `global-json` :
+```
+ {"ssl": {
+ "enabled": true,
+ "params": {
+ "server": {
+ "key_store_jks": "server.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "client": {
+ "key_store_jks": "client.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "admin": {
+ "key_store_jks": "admin.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ }
+ }
+ }
+ }
+```
+Options `key_store_jks` and `trust_store_jks` is paths.
Review Comment:
... **are** paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771319700
##########
modules/ducktests/README.md:
##########
@@ -77,24 +77,91 @@ You may set versions (products) using `@ignite_versions` decorator at code
```
or passing versions set via globals during the execution
```
---globals-json, eg: {"ignite_versions":["2.8.1", "dev"]}
+--global-json, eg: {"ignite_versions":["2.8.1", "dev"]}
```
You may also specify product prefix by `project` param at globals, for example:
```
---globals-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
+--global-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
```
will execute tests on `ignite-2.8.1, fork-2.8.1, fork-dev`
## Run tests from the external source/repository
TBD
# Special runs
+## Run with FlightRecorder (JFR)
+To run ignite with flight recorder you should enable `jfr_enabled` through globals, for example:
+```
+--global-json, eg: {"jfr_enabled":true}
+```
+## Run with safepoints logging
+Safepoint logging is disabled by default, to enable it, you need to pass `true` for `safepoint_log_enabled` for example:
+```
+--global-json, eg: {"safepoint_log_enabled":true}
+```
## Run with enabled security
### Run with SSL enabled
-TBD
+To enable ssl it is only required to pass `enabled` for `ssl` in globals:
+```
+--global-json, eg: {"ssl":{"enabled":true}}
+```
+
+You can configure ignite ssl connection by passing configs from this structure to `global-json` :
+```
+ {"ssl": {
+ "enabled": true,
+ "params": {
+ "server": {
+ "key_store_jks": "server.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "client": {
+ "key_store_jks": "client.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "admin": {
+ "key_store_jks": "admin.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ }
+ }
+ }
+ }
+```
+Options `key_store_jks` and `trust_store_jks` is paths.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1768136152
##########
modules/ducktests/tests/ignitetest/services/utils/jvm_utils.py:
##########
@@ -31,14 +31,14 @@
def create_jvm_settings(heap_size=DEFAULT_HEAP, gc_settings=JVM_PARAMS_GC_G1, generic_params=JVM_PARAMS_GENERIC,
- gc_dump_path=None, oom_path=None, vm_error_path=None):
+ gc_dump_path=None, oom_path=None, vm_error_path=None,):
"""
Provides settings string for JVM process.
param opts: JVM options to merge. Adds new or rewrites default values. Can be list or string.
"""
gc_dump = ""
if gc_dump_path:
- gc_dump = "-verbose:gc -Xloggc:" + gc_dump_path
+ gc_dump = "-Xlog:gc:" + gc_dump_path
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762265845
##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -27,6 +27,7 @@
# globals:
JFR_ENABLED = "jfr_enabled"
IGNITE_TEST_CONTEXT_CLASS_KEY_NAME = "IgniteTestContext"
+SAFEPOINT_LOGS_DISABLED = "SafePointLogsDisabled"
Review Comment:
Please use the snake case for global variable name (in other words follow the existing approach of already existing variables: jfr_enabled, ignite_versions, jmx_remote etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771319156
##########
modules/ducktests/tests/checks/utils/check_ignite_spec.py:
##########
@@ -81,17 +81,19 @@ def check_default_jvm_options__are_not_used__if_merge_with_default_is_false(serv
def check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt(service):
service.context.globals[JFR_ENABLED] = True
- spec = IgniteApplicationSpec(service, jvm_opts="-XX:-UnlockCommercialFeatures")
- assert "-XX:-UnlockCommercialFeatures" in spec.jvm_opts
- assert "-XX:-UnlockCommercialFeatures" in spec.jvm_opts
- assert spec.jvm_opts.index("-XX:-UnlockCommercialFeatures") >\
- spec.jvm_opts.index("-XX:+UnlockCommercialFeatures")
+ spec = IgniteApplicationSpec(service, jvm_opts="-XX:-FlightRecorder")
+ assert "-XX:-FlightRecorder" in spec.jvm_opts
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762256671
##########
modules/ducktests/tests/checks/utils/check_ignite_spec.py:
##########
@@ -79,19 +78,10 @@ def check_default_jvm_options__are_not_used__if_merge_with_default_is_false(serv
assert len(spec.jvm_opts) == 0
-def check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt(service):
Review Comment:
Even if the UnlockCommercialFeatures option is not used for JVM 11+ anymore it's not a reason to drop the test for the boolean options support. Just choose another boolean option. The -XX:+FlightRecorder would be ok I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1768137294
##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -27,6 +27,7 @@
# globals:
JFR_ENABLED = "jfr_enabled"
IGNITE_TEST_CONTEXT_CLASS_KEY_NAME = "IgniteTestContext"
+SAFEPOINT_LOGS_DISABLED = "SafePointLogsDisabled"
Review Comment:
Done
##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -27,6 +27,7 @@
# globals:
JFR_ENABLED = "jfr_enabled"
IGNITE_TEST_CONTEXT_CLASS_KEY_NAME = "IgniteTestContext"
+SAFEPOINT_LOGS_DISABLED = "SafePointLogsDisabled"
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771324999
##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -27,6 +27,7 @@
# globals:
JFR_ENABLED = "jfr_enabled"
IGNITE_TEST_CONTEXT_CLASS_KEY_NAME = "IgniteTestContext"
+SAFEPOINT_LOGS_DISABLED = "SafePointLogsDisabled"
Review Comment:
just for record
After all it was decided to have it False by default to not increase total logs size in results for tests which do not need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771263469
##########
modules/ducktests/tests/checks/utils/check_ignite_spec.py:
##########
@@ -81,17 +81,19 @@ def check_default_jvm_options__are_not_used__if_merge_with_default_is_false(serv
def check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt(service):
service.context.globals[JFR_ENABLED] = True
- spec = IgniteApplicationSpec(service, jvm_opts="-XX:-UnlockCommercialFeatures")
- assert "-XX:-UnlockCommercialFeatures" in spec.jvm_opts
- assert "-XX:-UnlockCommercialFeatures" in spec.jvm_opts
- assert spec.jvm_opts.index("-XX:-UnlockCommercialFeatures") >\
- spec.jvm_opts.index("-XX:+UnlockCommercialFeatures")
+ spec = IgniteApplicationSpec(service, jvm_opts="-XX:-FlightRecorder")
+ assert "-XX:-FlightRecorder" in spec.jvm_opts
Review Comment:
We have here 2 identical asserts.
I think one of them should be replaced with the
`assert "-XX:+FlightRecorder" in spec.jvm_opts`
Otherwise it doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11536:
URL: https://github.com/apache/ignite/pull/11536#issuecomment-2369023226
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11536) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11536&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11536&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11536&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11536&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11536&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11536)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762256671
##########
modules/ducktests/tests/checks/utils/check_ignite_spec.py:
##########
@@ -79,19 +78,10 @@ def check_default_jvm_options__are_not_used__if_merge_with_default_is_false(serv
assert len(spec.jvm_opts) == 0
-def check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt(service):
Review Comment:
Even if UnlockCommercialFeatures option is not used for JVM 11+ anymore it's not a reason to drop the test for the boolean options support. Just choose another boolean option. The -XX:+FlightRecorder would be ok I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "ivandasch (via GitHub)" <gi...@apache.org>.
ivandasch merged PR #11536:
URL: https://github.com/apache/ignite/pull/11536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762260129
##########
modules/ducktests/tests/ignitetest/services/utils/jvm_utils.py:
##########
@@ -31,14 +31,14 @@
def create_jvm_settings(heap_size=DEFAULT_HEAP, gc_settings=JVM_PARAMS_GC_G1, generic_params=JVM_PARAMS_GENERIC,
- gc_dump_path=None, oom_path=None, vm_error_path=None):
+ gc_dump_path=None, oom_path=None, vm_error_path=None,):
Review Comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762259161
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -102,6 +102,10 @@ def __get_default_jvm_opts(self):
oom_path=os.path.join(self.service.log_dir, "out_of_mem.hprof"),
vm_error_path=os.path.join(self.service.log_dir, "hs_err_pid%p.log"))
+ if not self.service.context.globals.get(SAFEPOINT_LOGS_DISABLED, False):
+ default_jvm_opts = merge_jvm_settings(
+ default_jvm_opts, ["-Xlog:safepoint:" + os.path.join(self.service.log_dir, "safepoint.log")])
Review Comment:
Please use more readable settings for log file like:
-Xlog:safepoint*=debug:file=/mnt/service/logs/safepoint.log:time,uptime,level,tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771025574
##########
modules/ducktests/README.md:
##########
@@ -77,24 +77,91 @@ You may set versions (products) using `@ignite_versions` decorator at code
```
or passing versions set via globals during the execution
```
---globals-json, eg: {"ignite_versions":["2.8.1", "dev"]}
+--global-json, eg: {"ignite_versions":["2.8.1", "dev"]}
```
You may also specify product prefix by `project` param at globals, for example:
```
---globals-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
+--global-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
```
will execute tests on `ignite-2.8.1, fork-2.8.1, fork-dev`
## Run tests from the external source/repository
TBD
# Special runs
+## Run with FlightRecorder (JFR)
+To run ignite with flight recorder you should enable `jfr_enabled` through globals, for example:
+```
+--global-json, eg: {"jfr_enabled":true}
+```
+## Run with safepoints logging
+Safepoint logging is disabled by default, to enable it, you need to pass `true` for `safepoint_log_enabled` for example:
+```
+--global-json, eg: {"safepoint_log_enabled":true}
+```
## Run with enabled security
### Run with SSL enabled
-TBD
+To enable ssl it is only required to pass `enabled` for `ssl` in globals:
+```
+--global-json, eg: {"ssl":{"enabled":true}}
+```
+
+You can configure ignite ssl connection by passing configs from this structure to `global-json` :
+```
+ {"ssl": {
+ "enabled": true,
+ "params": {
+ "server": {
+ "key_store_jks": "server.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "client": {
+ "key_store_jks": "client.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "admin": {
+ "key_store_jks": "admin.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ }
+ }
+ }
+ }
+```
+Options `key_store_jks` and `trust_store_jks` is paths.
+If you start it with `/` it will be used as an absolute path, otherwise as a relative path.
Review Comment:
Relative to which directory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1768135803
##########
modules/ducktests/tests/checks/utils/check_ignite_spec.py:
##########
@@ -79,19 +78,10 @@ def check_default_jvm_options__are_not_used__if_merge_with_default_is_false(serv
assert len(spec.jvm_opts) == 0
-def check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt(service):
Review Comment:
Returned the test, tweaked it to check FlightRecorder in options
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -102,6 +102,10 @@ def __get_default_jvm_opts(self):
oom_path=os.path.join(self.service.log_dir, "out_of_mem.hprof"),
vm_error_path=os.path.join(self.service.log_dir, "hs_err_pid%p.log"))
+ if not self.service.context.globals.get(SAFEPOINT_LOGS_DISABLED, False):
+ default_jvm_opts = merge_jvm_settings(
+ default_jvm_opts, ["-Xlog:safepoint:" + os.path.join(self.service.log_dir, "safepoint.log")])
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762259973
##########
modules/ducktests/tests/ignitetest/services/utils/jvm_utils.py:
##########
@@ -31,14 +31,14 @@
def create_jvm_settings(heap_size=DEFAULT_HEAP, gc_settings=JVM_PARAMS_GC_G1, generic_params=JVM_PARAMS_GENERIC,
- gc_dump_path=None, oom_path=None, vm_error_path=None):
+ gc_dump_path=None, oom_path=None, vm_error_path=None,):
"""
Provides settings string for JVM process.
param opts: JVM options to merge. Adds new or rewrites default values. Can be list or string.
"""
gc_dump = ""
if gc_dump_path:
- gc_dump = "-verbose:gc -Xloggc:" + gc_dump_path
+ gc_dump = "-Xlog:gc:" + gc_dump_path
Review Comment:
Please use more readable settings for log file like
-Xlog:gc*=debug,gc+stats*=debug,gc+ergo*=debug:/mnt/service/logs/gc.log:uptime,time,level,tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "skorotkov (via GitHub)" <gi...@apache.org>.
skorotkov commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1762268361
##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -27,6 +27,7 @@
# globals:
JFR_ENABLED = "jfr_enabled"
IGNITE_TEST_CONTEXT_CLASS_KEY_NAME = "IgniteTestContext"
+SAFEPOINT_LOGS_DISABLED = "SafePointLogsDisabled"
Review Comment:
Please also change it *_enabled (with True by default). In all other variables we have enabled but not disabled.
Say "safepoint_log_enabled".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23196 [ducktests] Change JVM options to JDK11 ones [ignite]
Posted by "okreda1 (via GitHub)" <gi...@apache.org>.
okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1771319451
##########
modules/ducktests/README.md:
##########
@@ -77,24 +77,91 @@ You may set versions (products) using `@ignite_versions` decorator at code
```
or passing versions set via globals during the execution
```
---globals-json, eg: {"ignite_versions":["2.8.1", "dev"]}
+--global-json, eg: {"ignite_versions":["2.8.1", "dev"]}
```
You may also specify product prefix by `project` param at globals, for example:
```
---globals-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
+--global-json, eg: {"project": "fork" ,"ignite_versions": ["ignite-2.8.1", "2.8.1", "dev"]}
```
will execute tests on `ignite-2.8.1, fork-2.8.1, fork-dev`
## Run tests from the external source/repository
TBD
# Special runs
+## Run with FlightRecorder (JFR)
+To run ignite with flight recorder you should enable `jfr_enabled` through globals, for example:
+```
+--global-json, eg: {"jfr_enabled":true}
+```
+## Run with safepoints logging
+Safepoint logging is disabled by default, to enable it, you need to pass `true` for `safepoint_log_enabled` for example:
+```
+--global-json, eg: {"safepoint_log_enabled":true}
+```
## Run with enabled security
### Run with SSL enabled
-TBD
+To enable ssl it is only required to pass `enabled` for `ssl` in globals:
+```
+--global-json, eg: {"ssl":{"enabled":true}}
+```
+
+You can configure ignite ssl connection by passing configs from this structure to `global-json` :
+```
+ {"ssl": {
+ "enabled": true,
+ "params": {
+ "server": {
+ "key_store_jks": "server.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "client": {
+ "key_store_jks": "client.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ },
+ "admin": {
+ "key_store_jks": "admin.jks",
+ "key_store_password": "123456",
+ "trust_store_jks": "truststore.jks",
+ "trust_store_password": "123456"
+ }
+ }
+ }
+ }
+```
+Options `key_store_jks` and `trust_store_jks` is paths.
+If you start it with `/` it will be used as an absolute path, otherwise as a relative path.
Review Comment:
Specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org