[GitHub] [spark] Ngone51 commented on a change in pull request #31152: [SPARK-34089][CORE] HybridRowQueue should respect the configured memory mode

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #31152:
URL: https://github.com/apache/spark/pull/31152#discussion_r595790677



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/RowQueue.scala
##########
@@ -174,7 +174,8 @@ private[python] case class HybridRowQueue(
     tempDir: File,
     numFields: Int,
     serMgr: SerializerManager)
-  extends MemoryConsumer(memManager) with RowQueue {
+  extends MemoryConsumer(memManager, memManager.pageSizeBytes(), memManager.getTungstenMemoryMode)

Review comment:
       Default to ON_HEAP mode, I think, due to the historical reason(https://github.com/apache/spark/pull/31152#issuecomment-758703519). But it's also a little bit implicit without comments (I was considering adding comments to the constructor). Another thought is we could provide another layer interface, e.g., OnHeapMemoryConsumer for consumers who only supports ON_HEAP.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org