[GitHub] [tvm] masahi commented on a diff in pull request #15010: [Unity] Fix importing tvm.contrib.cutlass

["masahi (via GitHub)" <gi...@apache.org>]

masahi commented on code in PR #15010:
URL: https://github.com/apache/tvm/pull/15010#discussion_r1213847312


##########
python/tvm/relax/backend/contrib/cutlass.py:
##########
@@ -160,7 +162,7 @@ def _check_matmul(context: PatternCheckContext) -> bool:
 
     lhs_shape = lhs.struct_info.shape.values
     rhs_shape = rhs.struct_info.shape.values
-    return tvm.contrib.cutlass.build.is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
+    return is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)

Review Comment:
   Sorry I didn't notice that #15001 didn't revert the change in `contrib/cutlass.py` after the dep of `cutlass/build.py` to `contrib/cutlass.py` has been removed.
   
   Why do we need local import here? I thought it is fine for `contrib/cutlass.py` to depend on `cutlass/build.py`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org